From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbcCWHWR (ORCPT ); Wed, 23 Mar 2016 03:22:17 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:59580 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937AbcCWHWE (ORCPT ); Wed, 23 Mar 2016 03:22:04 -0400 X-IronPort-AV: E=Sophos;i="5.24,381,1454972400"; d="scan'208";a="170319703" Date: Wed, 23 Mar 2016 08:22:00 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Daniel Rosenberg cc: Daniel Campello , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: [PATCH] sdcardfs: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove NULL test, as the index variable of list_for-each_entry cannot be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- derived_perm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/sdcardfs/derived_perm.c +++ b/fs/sdcardfs/derived_perm.c @@ -112,7 +112,7 @@ void get_derived_permission(struct dentr void get_derive_permissions_recursive(struct dentry *parent) { struct dentry *dentry; list_for_each_entry(dentry, &parent->d_subdirs, d_child) { - if (dentry && dentry->d_inode) { + if (dentry->d_inode) { mutex_lock(&dentry->d_inode->i_mutex); get_derived_permission(parent, dentry); fix_derived_permission(dentry->d_inode);