From: Julia Lawall <julia.lawall@lip6.fr>
To: Joe Perches <joe@perches.com>
Cc: cocci <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: coccinelle: bool if (foo) return true; else return false;
Date: Tue, 19 Apr 2016 21:15:54 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1604192115300.2054@localhost6.localdomain6> (raw)
In-Reply-To: <1461093152.1917.26.camel@perches.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 643 bytes --]
On Tue, 19 Apr 2016, Joe Perches wrote:
> There's ~150 of these in the kernel.
>
> Maybe there's use for this conversion to be added
> to scripts/coccinelle/misc/boolreturn.cocci or in
> a separate file.
>
> $ cat booltruefalse.cocci
> @@
> identifier fn;
> expression e;
> typedef bool;
> symbol true;
> symbol false;
> @@
>
> bool fn ( ... )
> {
> <...
> - if (e) return true; else return false;
> + return e;
> ...>
> }
>
> @@
> identifier fn;
> expression e;
> @@
>
> bool fn ( ... )
> {
> <...
> - if (e) return false; else return true;
> + return !e;
> ...>
> }
Thanks for the suggestion. I will take care of it shortly.
julia
next prev parent reply other threads:[~2016-04-19 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 17:34 [PATCH -next] kernel: Replace ACCESS_ONCE with READ/WRITE_ONCE Davidlohr Bueso
2016-04-16 19:04 ` [PATCH] checkpatch: Whine about ACCESS_ONCE Joe Perches
2016-04-16 19:48 ` Joe Perches
2016-04-17 5:43 ` Julia Lawall
2016-04-17 8:27 ` Joe Perches
2016-04-17 11:17 ` Julia Lawall
2016-04-17 11:39 ` Julia Lawall
2016-04-17 16:02 ` Joe Perches
[not found] ` <alpine.DEB.2.02.1604171944500.2004@localhost6.localdomain6>
[not found] ` <1460915801.19090.100.camel@perches.com>
[not found] ` <alpine.DEB.2.02.1604172001410.2004@localhost6.localdomain6>
2016-04-19 19:12 ` coccinelle: bool if (foo) return true; else return false; Joe Perches
2016-04-19 19:15 ` Julia Lawall [this message]
2016-04-20 7:19 ` [Cocci] " Michael Stefaniuc
2016-04-20 7:25 ` Joe Perches
2016-04-17 17:26 ` [PATCH V2] checkpatch: Whine about ACCESS_ONCE Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1604192115300.2054@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®