From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbcD1NaV (ORCPT ); Thu, 28 Apr 2016 09:30:21 -0400 Received: from ns.pmeerw.net ([84.19.176.92]:34887 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbcD1NaS (ORCPT ); Thu, 28 Apr 2016 09:30:18 -0400 Date: Thu, 28 Apr 2016 15:30:13 +0200 (CEST) From: Peter Meerwald-Stadler To: One Thousand Gnomes cc: Lars-Peter Clausen , Crestez Dan Leonard , Daniel Baluta , Yong Li , Jonathan Cameron , Hartmut Knaack , =?ISO-8859-2?Q?Krzysztof_Koz=B3owski?= , Matt Ranostaj , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] iio: tmp006: Set correct iio name In-Reply-To: <20160428142458.09e498e2@lxorguk.ukuu.org.uk> Message-ID: References: <1461296584-11918-1-git-send-email-sdliyong@gmail.com> <43150fbd-37ac-2d51-dd87-f41670417b96@kernel.org> <571E854A.90404@gmail.com> <7621197a-95ed-239e-8baa-83014bc27a26@kernel.org> <571F49B0.4060407@metafoo.de> <571F588D.3010800@metafoo.de> <5720EFAA.3040407@intel.com> <5721C904.3010505@metafoo.de> <20160428142458.09e498e2@lxorguk.ukuu.org.uk> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > It's clearly wrong. But the problem is there might be an application that > > depends on the wrong behavior, the driver has been around for 2.5 years. So > > it's difficult to fix. We might just go ahead in this case and take the > > chance that nobody will complain. But if somebody complains this will bring > > us the wrath of the Linus. > > Not if you put it into next, test it, then into a new release as early as > possible (for -rc1), clearly document that it's got a user visible change > that should not matter with instructions if anyone hits this as a > bisection for their app failing to email so you know and can revert it. is this the only driver doing it wrong? pmeerw@pmeerw:/var/git/linux/drivers/iio$ rgrep "indio_dev->name = dev_name" . ./imu/inv_mpu6050/inv_mpu_core.c: indio_dev->name = dev_name(dev); ./light/lm3533-als.c: indio_dev->name = dev_name(&pdev->dev); ./dac/vf610_dac.c: indio_dev->name = dev_name(&pdev->dev); ./dac/stx104.c: indio_dev->name = dev_name(dev); ./dac/lpc18xx_dac.c: indio_dev->name = dev_name(&pdev->dev); ./adc/mcp3422.c: indio_dev->name = dev_name(&client->dev); ./adc/at91-sama5d2_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/vf610_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/ti_am335x_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/nau7802.c: indio_dev->name = dev_name(&client->dev); ./adc/da9150-gpadc.c: indio_dev->name = dev_name(dev); ./adc/lpc18xx_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/rockchip_saradc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/imx7d_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/cc10001_adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/berlin2-adc.c: indio_dev->name = dev_name(&pdev->dev); ./adc/exynos_adc.c: indio_dev->name = dev_name(&pdev->dev); ./temperature/tmp006.c: indio_dev->name = dev_name(&client->dev); ./chemical/ams-iaq-core.c: indio_dev->name = dev_name(&client->dev); ./chemical/vz89x.c: indio_dev->name = dev_name(&client->dev); ./humidity/si7005.c: indio_dev->name = dev_name(&client->dev); ./humidity/hdc100x.c: indio_dev->name = dev_name(&client->dev); ./humidity/si7020.c: indio_dev->name = dev_name(&client->dev); regards, p. -- Peter Meerwald-Stadler +43-664-2444418 (mobile)