From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbcFGFX2 (ORCPT ); Tue, 7 Jun 2016 01:23:28 -0400 Received: from ns.pmeerw.net ([84.19.176.92]:45098 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbcFGFXZ (ORCPT ); Tue, 7 Jun 2016 01:23:25 -0400 Date: Tue, 7 Jun 2016 07:23:19 +0200 (CEST) From: Peter Meerwald-Stadler To: Alison Schofield cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: light: tcs3414: use iio helper function to guarantee direct mode In-Reply-To: <20160607050913.GA26916@d830.WORKGROUP> Message-ID: References: <20160607050913.GA26916@d830.WORKGROUP> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Replace the code that guarantees the device stays in direct mode > with iio_device_claim_direct_mode() which does same. This allows > removal of an unused lock in the device private global data. Acked-by: Peter Meerwald-Stadler > Signed-off-by: Alison Schofield > Cc: Daniel Baluta > --- > drivers/iio/light/tcs3414.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c > index f90f8c5..8a15fb5 100644 > --- a/drivers/iio/light/tcs3414.c > +++ b/drivers/iio/light/tcs3414.c > @@ -53,7 +53,6 @@ > > struct tcs3414_data { > struct i2c_client *client; > - struct mutex lock; > u8 control; > u8 gain; > u8 timing; > @@ -134,16 +133,16 @@ static int tcs3414_read_raw(struct iio_dev *indio_dev, > > switch (mask) { > case IIO_CHAN_INFO_RAW: > - if (iio_buffer_enabled(indio_dev)) > - return -EBUSY; > - mutex_lock(&data->lock); > + ret = iio_device_claim_direct_mode(indio_dev); > + if (ret) > + return ret; > ret = tcs3414_req_data(data); > if (ret < 0) { > - mutex_unlock(&data->lock); > + iio_device_release_direct_mode(indio_dev); > return ret; > } > ret = i2c_smbus_read_word_data(data->client, chan->address); > - mutex_unlock(&data->lock); > + iio_device_release_direct_mode(indio_dev); > if (ret < 0) > return ret; > *val = ret; > @@ -288,7 +287,6 @@ static int tcs3414_probe(struct i2c_client *client, > data = iio_priv(indio_dev); > i2c_set_clientdata(client, indio_dev); > data->client = client; > - mutex_init(&data->lock); > > indio_dev->dev.parent = &client->dev; > indio_dev->info = &tcs3414_info; > -- Peter Meerwald-Stadler +43-664-2444418 (mobile)