From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932839AbcFLUjM (ORCPT <rfc822;w@1wt.eu>);
	Sun, 12 Jun 2016 16:39:12 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60320
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S932360AbcFLUjL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Jun 2016 16:39:11 -0400
X-IronPort-AV: E=Sophos;i="5.26,463,1459807200"; 
   d="scan'208";a="181009763"
Date: Sun, 12 Jun 2016 22:39:06 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: Deepa Dinamani <deepa.kernel@gmail.com>
cc: Julia Lawall <julia.lawall@lip6.fr>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags
In-Reply-To: <CABeXuvpRtzrjWCOqbBJdTMaadVTRBqK5cpCO=OK8wUsNeoY6zg@mail.gmail.com>
Message-ID: <alpine.DEB.2.02.1606122237540.2180@localhost6.localdomain6>
References: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com> <alpine.DEB.2.02.1606122113450.2180@localhost6.localdomain6> <CABeXuvpRtzrjWCOqbBJdTMaadVTRBqK5cpCO=OK8wUsNeoY6zg@mail.gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 12 Jun 2016, Deepa Dinamani wrote:

> >> Documentation/coccinelle.txt suggests using the SPFLAGS
> >> make variable to pass additional options to spatch.
> >>
> >> Reorder the way SPFLAGS is added to FLAGS, to allow
> >> for options in the SPFLAGS to override the default
> >> --very-quiet option.
> >>
> >> Similarly, rearrage the FLAGS for org or report mode.
> >> This allows for overriding of the default --no-show-diff
> >> option through SPFLAGS.
> >
> > The first looks like a good idea, but do you find a use case for the
> > second?  The diff that is shown in org or report mode may be sort of
> > random.  It is just an easy hack to reuse the same pattern code for
> > context, org, and report modes, but there isn't an intent to see the diff
> > produced by context mode in org or report mode.
> 
> I thought this at first, that org report mode wouldn't need it the diff.
> But if a user wishes to override the option, then why should we not
> accept that the user knows what they are doing?

I guess... Another issue is that the org/report mode output comes from 
python, and the diff output comes from ocaml.  They are not synchronized.  
Ie, the report won't come out next to the relevant diff.

julia