From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933662AbcFLVqE (ORCPT <rfc822;w@1wt.eu>);
	Sun, 12 Jun 2016 17:46:04 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:25473
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S932991AbcFLVqC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Jun 2016 17:46:02 -0400
X-IronPort-AV: E=Sophos;i="5.26,463,1459807200"; 
   d="scan'208";a="181012031"
Date: Sun, 12 Jun 2016 23:45:57 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr>
cc: Deepa Dinamani <deepa.kernel@gmail.com>, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>, Julia Lawall <Julia.Lawall@lip6.fr>,
        Gilles Muller <Gilles.Muller@lip6.fr>, Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags
In-Reply-To: <92dd8f8e-7ee1-42df-66c9-95d8cca7210f@imag.fr>
Message-ID: <alpine.DEB.2.02.1606122345410.2180@localhost6.localdomain6>
References: <1465758279-16111-1-git-send-email-deepa.kernel@gmail.com> <92dd8f8e-7ee1-42df-66c9-95d8cca7210f@imag.fr>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1840809391-1465767958=:2180"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1840809391-1465767958=:2180
Content-Type: TEXT/PLAIN; charset=utf-8
Content-Transfer-Encoding: 8BIT



On Sun, 12 Jun 2016, Nicolas Palix (LIG) wrote:

> Le 12/06/16 à 21:04, Deepa Dinamani a écrit :
> > Documentation/coccinelle.txt suggests using the SPFLAGS
> > make variable to pass additional options to spatch.
> > 
> > Reorder the way SPFLAGS is added to FLAGS, to allow
> > for options in the SPFLAGS to override the default
> > --very-quiet option.
> > 
> > Similarly, rearrage the FLAGS for org or report mode.
> > This allows for overriding of the default --no-show-diff
> > option through SPFLAGS.
> > 
> > Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> > Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> > Cc: Gilles Muller <Gilles.Muller@lip6.fr>
> > Cc: Nicolas Palix <nicolas.palix@imag.fr>
> Acked-By: Nicolas Palix <nicolas.palix@imag.fr>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> > Cc: Michal Marek <mmarek@suse.com>
> > ---
> >  scripts/coccicheck | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index dd85a45..f662786 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -25,7 +25,7 @@ else
> >  	NPROC="$J"
> >  fi
> > 
> > -FLAGS="$SPFLAGS --very-quiet"
> > +FLAGS="--very-quiet $SPFLAGS"
> > 
> >  # spatch only allows include directories with the syntax "-I include"
> >  # while gcc also allows "-Iinclude" and "-include include"
> > @@ -72,7 +72,7 @@ if [ "$MODE" = "chain" ] ; then
> >  	echo 'All available modes will be tried (in that order): patch,
> > report, context, org'
> >      fi
> >  elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
> > -    FLAGS="$FLAGS --no-show-diff"
> > +    FLAGS="--no-show-diff $FLAGS"
> >  fi
> > 
> >  if [ "$ONLINE" = "0" ] ; then
> > 
> 
> 
> -- 
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
> 
> 
--8323328-1840809391-1465767958=:2180--