From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423903AbcFNFIb (ORCPT ); Tue, 14 Jun 2016 01:08:31 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:10541 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423811AbcFNFI3 (ORCPT ); Tue, 14 Jun 2016 01:08:29 -0400 X-IronPort-AV: E=Sophos;i="5.26,470,1459807200"; d="scan'208";a="222310358" Date: Tue, 14 Jun 2016 07:08:27 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: Wolfram Sang , cocci@systeme.lip6.fr, mmarek@suse.com, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options In-Reply-To: <20160613212249.GR11948@wotan.suse.de> Message-ID: References: <20160610214357.GA1650@katana> <20160610214900.GH11948@wotan.suse.de> <20160610215126.GB1650@katana> <20160610220831.GI11948@wotan.suse.de> <20160610222521.GJ11948@wotan.suse.de> <20160611054625.GA1824@katana> <20160613183759.GN11948@wotan.suse.de> <20160613185521.GB2238@katana> <20160613212249.GR11948@wotan.suse.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > On Mon, Jun 13, 2016 at 09:48:30PM +0200, Julia Lawall wrote: > > > > > > On Mon, 13 Jun 2016, Wolfram Sang wrote: > > > > > > > > > Is there another scripts/coccinelle/ file I can use to test against to demo > > > > against glimpse/idutils/gitgrep best? > > > > > > I'd think this one may be a candidate: > > > > > > scripts/coccinelle/misc/irqf_oneshot.cocci > > > > > > Not too many, but quite some matches over the tree. > > > > Seems like a reasonable choice. > > With this one on a 32-core system, I get: > > glimpse: > real 0m6.549s > user 0m49.136s > sys 0m3.076s > > idutils: > real 0m6.749s > user 0m51.936s > sys 0m3.876s > > gitgrep: > real 0m6.805s > user 0m51.572s > sys 0m4.432s > > coccigrep: > real 0m16.369s > user 0m58.712s > sys 0m5.064s > > I redirected stderr to stdout, and verified glimpse output has: > > glimpse request = request_threaded_irq > > Does this match expectations? Yes. I'm not sure that gitgrep would work as well when there are multiple keywords. It may descend to coccigrep. julia