From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753763AbcFOUbq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 16:31:46 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:64218 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751907AbcFOUbn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 16:31:43 -0400
X-IronPort-AV: E=Sophos;i="5.26,477,1459807200"; 
   d="scan'208";a="222600894"
Date: Wed, 15 Jun 2016 22:31:40 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@localhost6.localdomain6
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
cc: Michal Marek <mmarek@suse.com>, Gilles Muller <Gilles.Muller@lip6.fr>,
        nicolas.palix@imag.fr, linux-kernel@vger.kernel.org,
        cocci@systeme.lip6.fr
Subject: Re: [PATCH 2/4] scripts: add reqs python library
In-Reply-To: <20160615202633.GA11948@wotan.suse.de>
Message-ID: <alpine.DEB.2.02.1606152231160.2150@localhost6.localdomain6>
References: <1465942217-14452-1-git-send-email-mcgrof@kernel.org> <1465942217-14452-3-git-send-email-mcgrof@kernel.org> <576108B3.30008@suse.com> <20160615160224.GP11948@wotan.suse.de> <5761A871.8000409@suse.com> <20160615202633.GA11948@wotan.suse.de>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Wed, 15 Jun 2016, Luis R. Rodriguez wrote:

> On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote:
> > Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a):
> > > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote:
> > >> On 2016-06-15 00:10, Luis R. Rodriguez wrote:
> > >>> +        weight = (int(rel_specs['VERSION'])    << 32) + \
> > >>> +                 (int(rel_specs['PATCHLEVEL']) << 16) + \
> > >>> +                 (sublevel   		       << 8 ) + \
> > >>> +                 (extra * 60) + (relmod * 2)
> > >>
> > >> This is going to silently break as soon as we have a version number with
> > >> e.g. a time stamp embedded. 
> > > 
> > > Well this is adhering to a linux_version_cmp type, surely we can adjust
> > > it with alternatives. It just happens that with the common stuff this
> > > suffices.
> > > 
> > > Do you have a specific string in mind I can use to test against?
> > 
> > You can have a look at the git history of scripts/ld-version.sh.
> 
> Will use that instead. The SmPL patch can then have:
> 
> // Requires: 1.0.5

This would be ideal, I think.

julia