From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbcFUU0P (ORCPT ); Tue, 21 Jun 2016 16:26:15 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58669 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbcFUU0N (ORCPT ); Tue, 21 Jun 2016 16:26:13 -0400 X-IronPort-AV: E=Sophos;i="5.26,506,1459807200"; d="scan'208";a="182054995" Date: Tue, 21 Jun 2016 22:13:31 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: Gilles Muller , nicolas.palix@imag.fr, mmarek@suse.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, markivx@codeaurora.org, stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com, broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, deepa.kernel@gmail.com, cocci@systeme.lip6.fr Subject: Re: [PATCH v3 0/8] coccicheck: modernize In-Reply-To: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> Message-ID: References: <1466536893-23355-1-git-send-email-mcgrof@kernel.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: > This v3 series addresses the feedback from the last v2 series > on the coccicheck enhancements [0], namely: > > o it drops the indexing heuristics in favor for a .cocciconfig use > o drops glimpse support as its simply not well maintained, recommends > idutils instead. > o adds a Linux .cocciconfig -- the assumption is you'd run spatch when > you're at the top level of the kernel. This has not only the side effect > of picking up .cocciconfig, but also that the coccicheck use of the > make variables passed on are assumed to be correct given the base > directory as the current directory. I don't understand this point. Coccinelle picks up the .cocciconfig, if any, of the directory on which you want to work, not of the current one. julia > o makes SPFLAGS more useful by ensuring it is always at the end of options > o rebases on top of Deepa Dinamani's patch > "coccicheck: Allow for overriding spatch flags", under the assumption this > is already merged. I don't see it on linux-next but I do think Michal > has merged already onto his tree. This is also rebased on to linux-next > next-20160621 > > These changes are also visible on kernel.org, on a branch based on linux-next > next-20160621 with Deepa's commit merged first. > > [0] http://lkml.kernel.org/r/1466116292-21843-1-git-send-email-mcgrof@kernel.org > [1] https://git.kernel.org/cgit/linux/kernel/git/mcgrof/linux-next.git/log/?h=20160621-cocciconfig-v3 > > Luis R. Rodriguez (8): > coccicheck: move spatch binary check up > coccicheck: make SPFLAGS more useful > coccicheck: enable parmap support > coccicheck: replace --very-quiet with --quit when debugging > scripts: add Linux .cocciconfig for coccinelle > coccicheck: add support for requring a coccinelle version > coccicheck: refer to coccicheck bottest wiki for documentation > scripts/coccinelle: require coccinelle >= 1.0.4 on > device_node_continue.cocci > > .cocciconfig | 3 + > .gitignore | 1 + > scripts/coccicheck | 98 ++++++++++++++++++++-- > .../iterators/device_node_continue.cocci | 3 + > 4 files changed, 96 insertions(+), 9 deletions(-) > create mode 100644 .cocciconfig > > -- > 2.8.2 > >