From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982AbcF0N4w (ORCPT ); Mon, 27 Jun 2016 09:56:52 -0400 Received: from ns.pmeerw.net ([84.19.176.92]:41059 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbcF0N4u (ORCPT ); Mon, 27 Jun 2016 09:56:50 -0400 Date: Mon, 27 Jun 2016 15:56:48 +0200 (CEST) From: Peter Meerwald-Stadler To: Bijosh Thykkoottathil , Jonathan Cameron cc: "knaack.h@gmx.de" , "lars@metafoo.de" , "k.kozlowski@samsung.com" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] drivers:iio:light:isl29125: added macros for sensing range In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 24/06/16 12:16, Bijosh Thykkoottathil wrote: > > Added macros for sensing range as the corresponding magic numbers > > were used at multiple places. > > - SENSING_RANGE_0 for 375 lux full range > > - SENSING_RANGE_1 for 10k lux full range > Macros are great for making cases of 'magic numbers' more readable. > However here we are wrapping up 'real' numbers in macros that actually > obscure what they are... > > Now the fact they are used twice does make it a little more worthwhile. > Peter, what do you think? Your driver so up to you ;) I'm fine with the proposed change, but a proper prefix is required, hence ISL29125_SENSING_RANGE_0 and _1 regards, p. > > --- > > drivers/iio/light/isl29125.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/iio/light/isl29125.c b/drivers/iio/light/isl29125.c > > index e2945a2..83a5a7a 100644 > > --- a/drivers/iio/light/isl29125.c > > +++ b/drivers/iio/light/isl29125.c > > @@ -44,6 +44,9 @@ > > #define ISL29125_MODE_B 0x3 > > #define ISL29125_MODE_RGB 0x5 > > > > +#define SENSING_RANGE_0 5722 /* 375 lux full range */ > > +#define SENSING_RANGE_1 152590 /* 10k lux full range */ > > + > > #define ISL29125_MODE_RANGE BIT(3) > > > > #define ISL29125_STATUS_CONV BIT(1) > > @@ -140,9 +143,9 @@ static int isl29125_read_raw(struct iio_dev *indio_dev, > > case IIO_CHAN_INFO_SCALE: > > *val = 0; > > if (data->conf1 & ISL29125_MODE_RANGE) > > - *val2 = 152590; /* 10k lux full range */ > > + *val2 = SENSING_RANGE_1; /* 10k lux full range */ > > else > > - *val2 = 5722; /* 375 lux full range */ > > + *val2 = SENSING_RANGE_0; /* 375 lux full range */ > > return IIO_VAL_INT_PLUS_MICRO; > > } > > return -EINVAL; > > @@ -158,9 +161,9 @@ static int isl29125_write_raw(struct iio_dev *indio_dev, > > case IIO_CHAN_INFO_SCALE: > > if (val != 0) > > return -EINVAL; > > - if (val2 == 152590) > > + if (val2 == SENSING_RANGE_1) > > data->conf1 |= ISL29125_MODE_RANGE; > > - else if (val2 == 5722) > > + else if (val2 == SENSING_RANGE_0) > > data->conf1 &= ~ISL29125_MODE_RANGE; > > else > > return -EINVAL; > > > -- Peter Meerwald-Stadler +43-664-2444418 (mobile)