From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935566AbcIVXad (ORCPT ); Thu, 22 Sep 2016 19:30:33 -0400 Received: from mail-bn3nam01on0048.outbound.protection.outlook.com ([104.47.33.48]:14608 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933793AbcIVXa3 (ORCPT ); Thu, 22 Sep 2016 19:30:29 -0400 X-Greylist: delayed 3545 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Sep 2016 19:30:28 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=atull@opensource.altera.com; Date: Thu, 22 Sep 2016 14:53:34 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Paul Gortmaker CC: Moritz Fischer , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Ian Campbell , Dinh Nguyen , Devicetree List , "linux-arm-kernel@lists.infradead.org" , LKML , Alan Tull , Matthew Gerlach Subject: Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support In-Reply-To: <20160809160039.GX29630@windriver.com> Message-ID: References: <20160712193645.9098-1-atull@opensource.altera.com> <20160712193645.9098-7-atull@opensource.altera.com> <20160809160039.GX29630@windriver.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR12CA0008.namprd12.prod.outlook.com (10.162.96.146) To CY1PR03MB1520.namprd03.prod.outlook.com (10.163.17.26) X-MS-Office365-Filtering-Correlation-Id: 5ff874be-c3d0-4069-abf0-08d3e32301af X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;2:wksKBVT36a0Oekf0g/ZjVDp2Avtb0+slyF46mnzHokhTW2U6CCFb5BegZuiDwAXJ+ZsivZdFS4jrXq7mvAeuHts/Jfxq3UmgDmrngbgXsHsy1gntMehHVSLkiwu7g7cMyTstTyD1Zpkfy61bgqUB5Wi9rfCy2nUE1LZNh6M5C265tJLcj76+7+AjnQGYC4wA;3:61hG7LxqoTEEPM+pDIAdKJ2HkRxqbJcdjWRlAVJm1Pg3dqVIzAam0VcRZxtXUYfQhIyYlirVS7RLHWiJsUyptknnDZqDyQf2IhhOhe6vNjG/z6T8hMul0SsuPpi/xYWd X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1520; X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;25:HCQSvA269nONrp59YjpCT0pLI0u+xbNtCZMBjxs8xWJ3pC9cCMhuV7LT3ibIuUCojZ5/B5zkUivMhE6Kky/3cIun5W51CvFS5A8Fikrii1Uv2XBmS5/Mj8zw66oPCn/dfUKfa17QE8SBr+GOT8/ltiRIt9d+4U/fPqOyLds98ZveCWmhqPJcLhC7jAY3VQZetkd9KF1BhfCa+dv79HDnx1vigWNDm5l7lvmB8QTBrRLZzjLZq9JGzmGIfGPlWIH7mW+cAXQ4koVqM7ZutOu5qLCXw6CcjTfgMK9ZfEephGc8cvWeauc4syBHJC/Q1DDbd0o+sCbMJAsM/CFIkXRDKdm+6IwewtN3gEH4IT1cZPUubEiCs7a1FIndbV/U3Z6WWwd8DcGnbROzFHU5qyI2qRh0SLzqTy9LRBpFuXILGBaD1lhh9pkRi1MP91/csfy3MzKBx113c5dxguMrBrKKSMpKXTsA29VYyJaMMm3JoKtKE0O/2Rc0AwXxVF27WdHVIZ1IRuH86mEk/jZFHUgwFMOhayUPehAIhlzd3rObDyG5jFG18COuSa5KnPPClW9VBcZzT8RRQCV1YPt+WHND9ILlzv3ypTIH4E9uY9hPxA1VEc7PcpNeUuUwz2A8hhG4CoP6FKjohrFEZMAe7PAHQ+TwbjBnTi6RkNq8fN8qsk6OHhF9Td5ueiDhWpgiqfzETvtAiF4a9dw0ZqT1F7IxxQcen6xmmbXDSEQMwGtcmr8= X-LD-Processed: fbd72e03-d4a5-4110-adce-614d51f2077a,ExtAddr X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;31:Zlh+GKjYJsQW3fbZqphNyBLeM23/R7o6jNcixiGudsTQlo4XDg6GO6rKbxi9FxMtg/Zytm1l88c4Qcpg56qancsLhaZjwfqz4a3mTRz4kiWlvp2Xv4qdY8buVNgOyuPTIKkUufMO7fuVEt0wY2GipNAlHyS5PFhW3EtjysylkLo36FPXz93NI5Xc3JDMvdQ29oIyvnw9O96DXGr9NWyb4lg1A6ZyWAtlU6VO87vt85s=;20:NvbnXYH8WTKxG3BFy5hKikss5kDRSr84JjK+wOCqUw1TYN8suref8/bvsJsyPpxE37VQbYYucOIOsVhGT1nRvXSkdiPjUFGYk/W8kZuxyGJOYimTMY/lHQrm2+Pvz4zJ4P24s159e91I5lHk89XvUe2z4CYhCvULuZJO/jS38Ak=;4:oJxlucYtiBzKIUgkdRbCig6xLAk6yc+1GSLv41/uXbEUYSVVCGi9yEBwHIg52SYmYzFGdO/NY7FbsWUHKZnO4vLyuLmP59RCXLDq7/V5C48DxLmrbwqZds/Db7lslCOGun8i9SwS73G3HKXPraPpdOcXjIhuJsPRhVSqlj9q9maHVZagsrAGdLWQz9AfdDjn6Fqnwd3jQ49j9NbN3Qcsb5Fs32pGfF+fKPY97dE8QpTFKXyLO0VSJYFkTvJzma9Kx67Ri2ELw9UE6u7mPUHNTg7+NpoC9IUM8luCh2tpPLyZc49h1uX/4ZY31C06zikXBb7HDlCPcC8q0PlTt0GgHwz6r0XunHscu9Z7Lkq3m8GqPJfcqk5dHh0serlpin7MfGSPSOjqQBSA7JyNMkqGDc9bbKs6VWMqb84ajA0z9GRJLwG5+WLuCfh6NZbSF5hM29KA/jTVTZ9bbJ7m0FOuZQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757);UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:CY1PR03MB1520;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1520;BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13017025)(13018025)(5005006)(8121501046)(13023025)(13024025)(13015025)(10201501046)(3002001)(6055026);SRVR:CY1PR03MB1405;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1405; X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(377454003)(189002)(51914003)(24454002)(19580395003)(2906002)(4001430100002)(68736007)(189998001)(5660300001)(46406003)(93886004)(4326007)(92566002)(33716001)(19580405001)(107886002)(83506001)(6116002)(2950100001)(105586002)(7846002)(42186005)(110136003)(69596002)(50986999)(66066001)(76176999)(586003)(81166006)(81156014)(7736002)(7416002)(23726003)(97736004)(53416004)(3846002)(86362001)(4001350100001)(106356001)(86152002)(9686002)(101416001)(54356999)(47776003)(305945005)(50466002)(77096005)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1520;H:linuxheads99.altera.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?us-ascii?Q?1;CY1PR03MB1520;23:GaQmkfdDxFwUgNkdwH/hRNc9rT5iLoe7arPhyaYjI?= =?us-ascii?Q?PbDlTaGNDw2JxKoJP55Fdq/+AiKq1bmCmmVgvh/X+JCP5EoJOXDj14xQIdjL?= =?us-ascii?Q?1POkUIttD+HJH898B1M+M0QVD6tHbonJbf0F6lmUNjqwDWA0Xqf690lecPII?= =?us-ascii?Q?HHZz7ofOCbPH9sOjjrAdVvuVhNB1RunAIjuCB261mLVzl7sMCUwa5faNNzyK?= =?us-ascii?Q?qxr/eEMwNpDEUnsbrXeAjpmrF8uDhzaW5CmeOmv2FF1z8LIQZcGOoXelIB6Z?= =?us-ascii?Q?LxgUO40WWJo3HIn9/1hZQawSBEX3hcb6njq2DnR2AvOhgrySKKYa4HeTbEEz?= =?us-ascii?Q?y3hW/0sOzPtSr2R2XwUzp5WpDCWHhRWCWudaVeaE3KUt7nLzJXZPHlB52YIu?= =?us-ascii?Q?Z2kr81VllRuoB9U0h+9FzNJGlTCv71QV7zJxNytV7QLirCT4lXrU/wyuP6LL?= =?us-ascii?Q?TVqThhU2MFRaSpPfVUT2gjebbONQ7FM/6c1RkqSFGJ8F3XCwTov/QVxO+547?= =?us-ascii?Q?xl2G5KdR6VdgxyUD2UzqoDJMCziU4r7cG7fEU++pY+NhsWAPTbKkO9XM8e2s?= =?us-ascii?Q?BetVKDar+Z9ATtQXQu8Hby9juPuYZhW8eF8OGMkka3S38Nt2e13d/ypxnub1?= =?us-ascii?Q?qzwVs5D/aVKFDyFVwxQe98g1iYpuKyRDzucFfNLUQlauWh8JzY7nov/FBb1x?= =?us-ascii?Q?36gYZXUiJKtEqT39X8uoaLZTfcvgAFxkPqEP5qnV5U55FHmEy4JCVJKhycfb?= =?us-ascii?Q?5m8r+tRDtxrdu8pACXxm70PjANdq79Pqvb008JG3ODpevFhXlBE+e6vWsyLh?= =?us-ascii?Q?VJV5xHdou4slr1Srh/owMk0hAOMYKOrIBSHZ4RUQpPUQ93USkMn98x2PU/x2?= =?us-ascii?Q?dQMFF60MojyI6Le8CdIKxH/q5I4Ao0QhRaBNxaes4wUNZXlAdFhS5qpIMoFg?= =?us-ascii?Q?Ji5W/L/a3TA76J/nolNnLJ+1EE10ccaBQ8c41D1MqgBn3g1pn/f6EyW+rFWL?= =?us-ascii?Q?0NDgmjCjXafl/syC09nYzPFlFjqO041tyiuXVn60OfaaNFFIpo9iMLDPWPnP?= =?us-ascii?Q?DHY6woMheUJcMDKEJ0z2UquAQxejiklbMnQ1ZjortTov1MKbmzmb8uk+lOJW?= =?us-ascii?Q?XuOb/XgOphCzi7TDa83h9QdFIbSzVfYdEstpBtaKo8/pq58ZvjekCLz0DLdE?= =?us-ascii?Q?CrRnbosti+VIr/ZcIfR5vIp15u/thlYbCW7efCktWyIARAClnwaDqQt6OiZX?= =?us-ascii?Q?rJL2ydd5c4kCDEnufuOooYaGxJyUvH+b17aqAxGqiKOkaDD3NA7L9Chc3+x+?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1520;6:hx+pZ54wGLZDJ3OTz4+Ct5AqxeoFTbZ0ucvxgugd4GHd5LjyHqAK+853m1G7293LqjJ3DffZUycb/gx3wINUsdkwVaBneHfzZfL/ymXZJqEWnhFoOI7tMnMmie9z+xKvOi7Pc5znrSzhrH/oxilKGpg3Y1ax2MprAak9nBnMe40MB93I35OORvME4OweIgalRD/agFzeeNOLLFPlrBLMY4E1gKyzngzQjRPSF5X/jmPmCvSUfs1UmFLly+KmyJHwth2/7Ub0AOnJ0amqYM5v+zQ8HD+i2Dax913fLQWvtk+o49yp71PZwWYzVV43YayCoSXfDJo80gJyuQPLEVrqYA==;5:ffaTykhuTXJcUapODZRcu5qEXzYdLROrqWaYl//n3V+TGYAaQJPKeRtbSuf+dmX5GtEVV0RyFhaPx/XYsLZBkikfpWPR75taMP6RirtRlfDwnZpM8WWK195zvmN9wLtf9OIuf3uHBNB3T+//0jz56Q==;24:h80S5L62kfT6hIKWO8zytcz/R4LY3BeaYiVzkhXtPU9HemIJ1Sr8xLUiLE1z1D7wJCsw6oH5O74KMgULbDEPbr46/SwZiHwPdu7HJ5kWnWI=;7:qzlwAukVmyN+H0Fw02uj8zVDbf+9/ONwgp7EXi6YsY4AutXrAMQeEWPAkMN4O3b69oNVuqCvewMvjrHotjKHIdchDLpwOsvLH6X2TYTY40gUSUvIMf01rfAuAFCirI3ZUFCLnCzk9hI8uE3MbgvnacuQS2i6tcEaZ/1mmCVXJfptWZTZMdJqkhpqndhaXfM4xnTMGU2ss0Zmtp9tjFzNvAkWVfV9P1YV22506v4W4l/OuDOb6AWo8Lpbv2PRpMrctIGJRxeN2ipMQk38YMxKGJpd/CTkOlbbsUjavFCNlO++KffwlWJMddlHW+QfLPB6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1520 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.35.236.236;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(377454003)(189002)(24454002)(51914003)(7416002)(86152002)(92566002)(76176999)(81166006)(107886002)(54356999)(6070500001)(97736004)(16796002)(4001350100001)(93886004)(626004)(4001430100002)(305945005)(81156014)(356003)(86362001)(7846002)(7736002)(189998001)(47776003)(66066001)(8676002)(68736007)(5660300001)(106466001)(586003)(6116002)(23726003)(956001)(3846002)(19580405001)(33716001)(19580395003)(53416004)(9686002)(50986999)(46406003)(9576002)(336002)(50466002)(105606002)(110136003)(2906002)(85426001)(8936002)(83506001)(3720700001)(2950100001)(77096005)(4326007)(87936001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1405;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD063;1:lDHRw4Jrexe29F+OP8hvGoZWiNOtAREOX9MrfzYZmDpeH6bZtcYWNU30H9zgQ0R7lXOOqD+OdvRcuPaWClqsVjil0q2IXHjMaeNGh/yaqlv7MhZoVRAk1eZEMOmvHeXcGOYgB3TViziSDFX52GlmJ7DW+Ucc/mlf3BBx1QsawHlRdekrA5SdwobCzL0Sf/thm0EDZX+08j4/hY6A2w/4br+xOup9pB6WwjP4St9LpgqRRIVrGGwDmonn6RDC15I9GkwIm6dwPr+3yCl7h5FqDcW1S12ik7uNH1lgD9ob6Cw2i8zR4h+aVef6XccvrltZ4DbJ321rJfeR7kdUwp8U/bJ0jHpxNqwcj4uhQzh7ilitjCkG2IF9rkj0b4fbV4rURXo8OSVy1t3Ji75bQN69SLFRHvmAGC69iAj8J8tANsZvrEZcC2BvoRT3DRgw2slvC0SFuAr5VYecIqFHZmTyOJizDmGkkgNlwDFqGJEbqGXAeFz9JxDIPlDBf2/IDkQ7qluBqj+dTmXXsQSknNBdIhx4ksVdx88lIAI5IXAIXnT8mk2dWEDryeoyGW1++ImCoz/HcilSs42HlN2dhJbbkA== X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD063.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1405;2:l6dmEyChHKuF9TU2dryx9vOfzLlbbNZ0wfx1OMsJxbBkGynWSgZFanwSDtW3ZJWSL/FXFlyz+TtGnQMJAVQ2+NmtYbPrksV3GX9TzlPr8aZ+Oih28lvYbR6XIqGcWNokSGzMSOpyB/DAXU62TY+jf3FatBzGYC6q4SNSKROS/zDpNhB8MgpnJIaW97W/0myt;3:7L9F2+f+Rt2+fREZm+QJSBv2MfvJb5hyGzcdqEzXE8mGHk1CDnHDYQIJ87rpEcOgcHlMMNwg3ekm57MBy//QWpEC/lsCKNq9qI9RdxDjCYLFeqy7vpmkzmvkb3XpS7DRq6kDxy6XLnZfK0CxIY2U32wQIfp6p6NKz/yXcFK0BDfiSwuW+qF2uFP4MzqQd531AgzHzmztbZISeDyOtNszd2mQh8rV5xIzrjCTEkx4srPwF/g0AU09/nQS/3XOlDON X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:CY1PR03MB1405; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1405;25:bTnpplGUpWj/FSjidQWnLZJV6nRqxKwkKUWC4Y9aA80dkSJWGTyHDabUP37vwpR95UxwkoPlrzVuJQ5AyY7QndSOIplrM0MW7/aOvOI4ktgSWfbwX+E6RBxxGHxrjdqZmympZiPsYw9BBaDTZETAJzypsQBQDmWMzZoqZJYiQj0KFCxA9kHjjVBq1GhvC/3rV7oJptiATzOmBt2H5Yg7x46isCcO6jVeN4hyY/XtDexZN0R49JAZUG5SQUZUzGSrVaN04ClRL2oz7y9s08Ez4COhcsYv0RSQwYkFbgvniepod3bBrMkYg1C8PPYt6G7Ig7jAdbfYDt+pLGuOKDqO+YhjkT3jMxLUJZLFxV/C5wUJyuoI2zDegt0ltEAAGcwAMLOJJ7NdyTAAgukBmz61oVqiEGmgt/sAW08WX48gWQzC7yMHLfnzN1K4PfNiIX7+GZuX6TEfpyqoG6xucMdfiKHeQc+s7WU9Z82VvCRk1fHCOpCjRZ+PY+Q/AVdvd7Mj+MsUBmWsEbh+/XKzUMitYy74c0AXpiZc1Un1pokmwOdX50kl3ZCUl26HZdilKeyTM6QRml/eOdmQaQDN2gL3c4C/YRtaF8AZpdm60dxZFPvowlqMOsBDn2Q11PmQ7XALaRO3QYuPMo/4JSBPDX00pyGnWevm2FTtiM/dXobxqZFmS9TFX37H7/6+FCN7+hpd3iPA4hTAEnvCo74i7z4/Y0ycBSxx7RMyXlBn3uNSNoU9t0c/Vk4I9iHkSjmYIA+g X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1405;31:DkHU1l9jzh9+DgyD4Q9VllSVtDfK/EgVwL5FJLz77tKDSF6ZijTI206bwCgtVcPFnRy9PY8qG8juaAHtgbsSo+4UVJ8XYX7L90bwNG62kLzlKkLWkuEeSEh476QsG53/JDtqL2S6WwqEXivU0kHUrwRzMVh/u3T91NJnIn9Pv/Ss/iZR/M53xBuS2wPJgBK6mfryOHsZrYeFcJ2QpVKlhDEN+7BwIsTIaMCl2dIt7S8=;20:qBnXdmGKDjfI0anTbfRWMP8AXZ0T5rFw/tkM5+2o971m9vU8HkM9FVUkSPuHWY8f1K4B1uQmjM3FnKdsYThfdsufwCHTRjVZqxgnNep4sgl9cWWg89trZBwpaaPW6wBNFLopRbvr5AS7KRJHHno1VAQ8AFvMNUMhyCH4j+zE0FU=;4:Fs2UPzX2qi4IJTqjgtcQH/SsiIH5DcGCo9p2f761yJVx5ZiUyMXCHl2bFZujxT1e8Rf9VrBXYvpqrGBgKOkVZhUcq3GJttoyQnCUMGQkEvNr51mQ9+HFt3jhQfcdbSJ/G9EaEg2CNGh1+307HCoh5Ds7WAHCiYKVQyyHC9mn8QTUMfr0OHK/P6mJCA6d4epecvUudMuMxXBZqSQv4JMMDP9++wP5eiJo3m09Qe+zouDTW+VNPDG91JVBU8yV4tDgm8SlkI8IdmMvdapuKQ98zZ2uXIs4RkQvAUM8GTwcQrsvoYXd0rfW4sR9806x+KXYb04e/wr5HC7yrxKm4z1k4pmwVipkJdAtbYi5ITIVj31j9s7A5SqQ6srYqZw7DS0dzhod/jsU2ZOL9UNi8DGQDUI+mRB8rJF/t1XvhVWp19plJlxh9mTaF0QHGNtkYqW25q37FQZl71bheS1mgXM2WiQtu8UaeEoxp+ce+qKc6tlqlwTN32PFNhL7n2chz0J5EQcyfPnNIOizLRSfGYYvrf1TlvyYLFYn6epHWdVlynI= X-Forefront-PRVS: 0073BFEF03 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1405;23:3xTMyjuJGqm8CcRvMPLAzyYrXOWI6DTFihj5pl4Ai?= =?us-ascii?Q?fQ5iMagz/m459f9P9+ysjYRS5mZY2Nlm+o89aqBFpOqQNQlUBL6ThlQzeR3s?= =?us-ascii?Q?xp4Sz0KooRTS5vffEzUCeoVzEeKBE4Atk8q4RRchQkfuduklzp9xKZghi+FQ?= =?us-ascii?Q?WJnWBQ5ViSBQK4Z5MIyfMdTpKN0WKhFo26I3X8P294T8alWw45bKUeeSXWCD?= =?us-ascii?Q?38pmj73azzGL+tr6NuLawWKqSt7dC91nXlH16v8V1yXrjNwKwwtuniSVu3bU?= =?us-ascii?Q?bBmG4nCLLV0zrZbA6By1kaa+WpAmyAjo63CNyrfskJuG1NKmUC25saA1VRdz?= =?us-ascii?Q?Qde20R2xCidwHkgfbJ/VzSDEAHmzbfctdbnY315aqXimXPhDqHF05WwBDmxa?= =?us-ascii?Q?62+wM5aqtJNNUTiB6UIiE1V93O+fv3RlI4zbAPAZiHfL+ZHeL7GeHHPscl45?= =?us-ascii?Q?tZ4Wzs4+m8EZ/G1ahHeVhKfKavh0CLQatvGZIicVeryX13A9pUmINK0QyY0P?= =?us-ascii?Q?FCaKtWs+wUN6Xc2TpraBfxknPbF5t5R9Ccz7xA4oYqyeA5JFlYIFzRQzH1K5?= =?us-ascii?Q?gUn9uxuakOW30OA2us9Yr/MSllAQpOQhENEj5PQHh7fl9HQMbxAxUMqIU2Aa?= =?us-ascii?Q?r0jMp7599mg191Ul+AqFXV61hgYEA1S+PZKRllSuK0OqzWeAFn+TcTEqZxWh?= =?us-ascii?Q?ApNVX675k3blydSFdkwJ1Wf+MkUAAEXuLa9Smy4dJkf9MClQJxP63nZzQo48?= =?us-ascii?Q?Yc83VsHNXxMYj2sz9s47MjB7t74A8Z6Lbs4Q3CVlLEKq7iuLlRECr7pfq94k?= =?us-ascii?Q?uo8o381Ix+vwDwKd1hXsEp7sAquPczpdKVlk+3m1MpUUHf4a4eG0aRYKqs92?= =?us-ascii?Q?Za5HNNfHWxMr4g+tDJCXCv3v0fh6doVWSYT7z4JFf/ApIcyj6E+lUM3thu68?= =?us-ascii?Q?Pzcc8bX7nfYXZQXgHYn2t7zGP6ySVQTBxMzDm5wVnz4INcGdQogbQmGMtCDD?= =?us-ascii?Q?+R/svW5Mm4Go1cssWB09rR5K+JmKkjfkYIIXWyijLWcujgz8ssz0ECvJHQCY?= =?us-ascii?Q?PILRTNAgye7gWb+fvpYPrWzPgAY+V9Mq9JdIYA5R+/1u1HQciTQUxOfSFE1I?= =?us-ascii?Q?VHhIOleOUbk7ruWeknq/yLXYiXJu5rmJcnQ3+vyxSXVDZ7rNPz4PgRV2WMrD?= =?us-ascii?Q?nPR8xMDdwvdXEenouHMhQ6t0ZdYw6eXbQbWwPWtssQajFazIOASzCK89cVww?= =?us-ascii?Q?3Xaba5mDLYpsYIKyD2gaLKWK9amBKY9sI48c1sByQFNCXDYoKgrNOytsSTWS?= =?us-ascii?Q?GXKkBuGiShOR/8Y8dn81NjbR6Jg3dxpE3wawTmS04/DMqJF692xttHlRk5Gi?= =?us-ascii?Q?+eSyms5uKfsW2iK0dINfFnbCFtVb+zf9t6gu+4dyr6yERJP5ijG16TqfCvvw?= =?us-ascii?Q?CImpEJiQVVQ8IFPwfJyl7wrsjlUyG7FbwCq2r6FNleo2gAtbYE/+bCs7TnKH?= =?us-ascii?Q?sGL4Z6pKAvmHcfpS0GPsiwN9/GJazwi0LY=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1405;6:FvPyjj+ig3oWkpv2G4N4LzZ4DyVud8i/G7554V36lFcUOYj0fTZs91vdfz6vl3yHsJg0cheSAinoFMbjsYPOHJ8qz9s3SLA7TlUWjwZlMJhGL0g6fhVpGO7oYgsgy615VKfbbSudIgg5xJPdj/0WLApGXr3pcyh4cEDdZ4DD4DOXBuqnCIv2xXglOTzsKwB9zuqvlz1uQxUYF++PGOx26w6goyc56YGAbI6ezvPTxyUarjJxTTmg/dQQoVcnCY8+zKLRDr6e7aDpof7hHSgEYDBzE7BvjEFppXKMBovBpa4mLWV+5w6UaAVWnbJ5GYe2iUujSXN8TkuC6p9Q3sQLNQ==;5:zqhWW7e8PqInmlZFLY1f33nCKCJO4wss5LInBDnWBQ/JREjmzWMle2059HH48LiMRE9mbCAgDM3Mn5CW21Wrn5RaqV4focyoun7xmcN5IyZ+WKL5eqFsCv694ZHvkLElsatul05lDphdJ7y1qh799Q==;24:ZUvepdMGC0eWNjzhtifHG9wjgP7o032RLIuxZFcekH0foF77FQGXjZhG0qf3xsB2phlTSljN4IxNZbFsszZJOZTlS/bLFFfnzdoRgjV9TLY=;7:d/arWghpksMZCUJxW7pWgAzgIwC8paJuCshD5SlSUVBg0xz2evHjQrNljq6slbl/KvbQcw6mlPjtGCfjRT+FfY3gr3R29Osj/QgDoP4yH9tWOs/xz+BCkzUSYVUswxd+LXPu9y8eNDGDHax579P7cSPPS/i8mfMC9nIQ1JPla26SC8XkrY4TN70HGVsAsMIwMLg20gCa2Q14kVWXbe6PAaleljLNLfS182ktaMCHkEb3pEi/47lNiXZ8IngmblqezM3qFtCfiLQBee6qSTT2cA== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 19:59:47.3534 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1405 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Aug 2016, Paul Gortmaker wrote: > [Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support] On 08/08/2016 (Mon 13:44) Moritz Fischer wrote: > > > Hi Alan, > > > > On Mon, Aug 8, 2016 at 12:18 PM, atull wrote: > > > > >> Please don't use module.h in drivers controlled by a bool > > >> Kconfig setting. > > >> > > >> THanks, > > >> Paul. > > >> > > > > > > Thanks for the feedback. Can you provide an example of what you > > > would consider to be proper usage in the kernel? > > > > > > I think Paul is suggesting to use > > > > static int __init alt_fpga_bridge_init(void) > > { > > platform_driver_register(&alt_fpga_bridge_driver); > > } > > > > device_initcall(alt_fpga_bridge_init); > > > > or better: > > > > builtin_platform_driver(&alt_fpga_bridge_driver); > > > > Like for example in: drivers/cpuidle/cpuidle-mvebu-v7.c > > Yes, pretty much that -- if you have a bool Kconfig, you should be using > builtin registration functions, and have no need for module.h or > anything MODULE_ or any module_init/module_exit calls. > > An empty file containing nothing but #include will > cause cpp to emit about 750k of goop, so we really should only be using > it for drivers that are genuinely modular; i.e. tristate Kconfig. > > Thanks, > Paul. > -- > > > > > Cheers, > > > > Moritz > Thanks for the feedback and explanations! I've retested my stuff with it all built as modules (mgr, bridged, and fpga-region) and it all works that way as well as built in. So I'll fix up the Kconfig as tristates for everybody. Also I'll add some dependencies as FPGA_REGION should be dependent on FPGA_BRIDGE. Alan