From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883AbdBAJKJ (ORCPT ); Wed, 1 Feb 2017 04:10:09 -0500 Received: from ns.pmeerw.net ([84.19.176.92]:42668 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbdBAJKI (ORCPT ); Wed, 1 Feb 2017 04:10:08 -0500 Date: Wed, 1 Feb 2017 10:10:01 +0100 (CET) From: Peter Meerwald-Stadler To: Peter Rosin cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Alison Schofield , Gregor Boirie , Sanchayan Maity , Ken Lin , linux-iio@vger.kernel.org Subject: Re: [PATCH 1/2] iio: pressure: mpl3115: do not rely on structure field ordering In-Reply-To: <1485936567-3367-2-git-send-email-peda@axentia.se> Message-ID: References: <1485936567-3367-1-git-send-email-peda@axentia.se> <1485936567-3367-2-git-send-email-peda@axentia.se> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > Fixes a regression triggered by a change in the layout of > struct iio_chan_spec, but the real bug is in the driver which assumed > a specific structure layout in the first place. I don't think that this is a proper fix maybe the driver is unique in that it uses mask_separate for INFO_SCALE and not by_type, but since there is just one PRESSURE channel, it should be equivalent what do you mean by 'driver which assumed a specific structure'? thanks, p. > diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c > index cc3f84139157..525644a7442d 100644 > --- a/drivers/iio/pressure/mpl3115.c > +++ b/drivers/iio/pressure/mpl3115.c > @@ -190,7 +190,7 @@ static const struct iio_chan_spec mpl3115_channels[] = { > { > .type = IIO_PRESSURE, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), > - BIT(IIO_CHAN_INFO_SCALE), > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), > .scan_index = 0, > .scan_type = { > .sign = 'u', > @@ -203,7 +203,7 @@ static const struct iio_chan_spec mpl3115_channels[] = { > { > .type = IIO_TEMP, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), > - BIT(IIO_CHAN_INFO_SCALE), > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), > .scan_index = 1, > .scan_type = { > .sign = 's', > -- Peter Meerwald-Stadler +43-664-2444418 (mobile)