From: Mikulas Patocka <mikulas@twibright.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] hpfs: drop unneeded newline
Date: Mon, 1 Jan 2018 21:23:00 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1801012120300.14344@leontynka> (raw)
In-Reply-To: <1514386305-7402-13-git-send-email-Julia.Lawall@lip6.fr>
On Wed, 27 Dec 2017, Julia Lawall wrote:
> hpfs_error prints a newline at the end of the message string, so the
> message string does not need to include a newline explicitly. Done
> using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Mikulas Patocka <mikulas@twibright.com>
> ---
> fs/hpfs/dnode.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c
> index a4ad18a..fc1809b 100644
> --- a/fs/hpfs/dnode.c
> +++ b/fs/hpfs/dnode.c
> @@ -914,7 +914,8 @@ struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno,
> struct hpfs_dirent *de_end;
> int c1, c2 = 0;
>
> - if (!S_ISDIR(inode->i_mode)) hpfs_error(inode->i_sb, "map_dirent: not a directory\n");
> + if (!S_ISDIR(inode->i_mode))
> + hpfs_error(inode->i_sb, "map_dirent: not a directory");
> again:
> if (hpfs_sb(inode->i_sb)->sb_chk)
> if (hpfs_stop_cycles(inode->i_sb, dno, &c1, &c2, "map_dirent")) return NULL;
>
>
next prev parent reply other threads:[~2018-01-01 20:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 14:51 [PATCH 00/12] " Julia Lawall
2017-12-27 14:51 ` [PATCH 01/12] dac960: " Julia Lawall
2017-12-27 14:51 ` [PATCH 02/12] dlm: " Julia Lawall
2017-12-27 14:51 ` [PATCH 03/12] net: dccp: " Julia Lawall
2018-01-02 18:50 ` David Miller
2017-12-27 14:51 ` [PATCH 04/12] ext2: " Julia Lawall
2017-12-28 4:30 ` Theodore Ts'o
2018-01-02 13:42 ` Jan Kara
2017-12-27 14:51 ` [PATCH 05/12] openvswitch: " Julia Lawall
2018-01-02 18:50 ` David Miller
2017-12-27 14:51 ` [PATCH 06/12] [S390] dasd: " Julia Lawall
2017-12-27 14:51 ` [PATCH 07/12] ARM: davinci: " Julia Lawall
2018-01-05 13:56 ` Sekhar Nori
2017-12-27 14:51 ` [PATCH 08/12] perf test: " Julia Lawall
2017-12-27 14:51 ` [PATCH 09/12] [media] pvrusb2: " Julia Lawall
2017-12-27 14:51 ` [PATCH 10/12] hpsa: " Julia Lawall
2018-01-04 4:29 ` Martin K. Petersen
2017-12-27 14:51 ` [PATCH 11/12] drm/amd/powerplay: " Julia Lawall
2017-12-27 15:40 ` Michel Dänzer
2017-12-27 20:11 ` Julia Lawall
2018-01-01 21:07 ` Alex Deucher
2017-12-27 14:51 ` [PATCH 12/12] hpfs: " Julia Lawall
2018-01-01 20:23 ` Mikulas Patocka [this message]
2018-01-02 13:52 ` [Cluster-devel] [PATCH 00/12] " Bob Peterson
2018-01-02 13:55 ` Julia Lawall
2018-01-02 13:56 ` Bob Peterson
2018-01-02 14:00 ` Julia Lawall
2018-01-02 15:11 ` Bart Van Assche
2018-01-02 15:16 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1801012120300.14344@leontynka \
--to=mikulas@twibright.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®