From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2256KV2YjKgNeslrunVjLklGFPZdi2gNAQgBXciwXqXXpu2dLtO0Ob/nZBWuBgcLQZfsEryf ARC-Seal: i=1; a=rsa-sha256; t=1516639979; cv=none; d=google.com; s=arc-20160816; b=N9RRgDSpDhpnMQCLuISTmAMlufY9poXwedp5QuU/vpENBirCZtTERwVAs2w4jYS4UW ORO0aRzRcFbiyDT7Q6kfiGmI4ck8bOYnjSgqIk8uUAFWw/oGpGOwLUofvWWkmFQ7Mubt 6BRxjpdKb6gfVvDc6aDRT3lW9gjKHcqJQ1z6Vv+lvndAG7o8sZ0enTBq1ZacorExkW4B yuYSS05UGss7dQ1UkSVGQrpWEyYbOBT3b1xugzDLXzmz2DD9OCO/8mcjnuVsp582GMpX 38DLmIE5pnLdr47rV6qOeW8shzRnJDzsJaxofNWEZ+uBkJWXp9efaslINLlR5jmDKyFt 83+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=wU1QPMTbLqlDX7mT/cJ4PLua11uegyF/GzUp7I4Hf44=; b=Osnsv0LGXQTjqr5ELmW56R6ldX+xQoEpuwIP8ybB6EYBMpS67wRSVbDzSrec8bQfM1 m7vei05+Akp2KQkDpgPPaAlzXBwwbcWaoF7zJ29rEQZCGvYcoNruwA4SER0+NmSIHOpF pGb3V+tFfHmd/B9EesvVVTi8DMBt/XRWrpJLYA8gkJl37fQAv+kE7ncLTXodZ6kRmKXF Kl+drou/h5AVYvsRO/7E7MwIcarEXJ04UtVjHCkjQC1CXDq51H4+q6/foWX0+OCjzNo3 Mujkfu8ggjcCD+QFaZANwzqK5jCqm6cicALCVR1KGABYglKJmddKkkPyzTQqu7OYhgaA mULw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=OCcq8zZf; dkim=pass header.i=@codeaurora.org header.s=default header.b=OCcq8zZf; spf=pass (google.com: domain of lmark@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=lmark@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=OCcq8zZf; dkim=pass header.i=@codeaurora.org header.s=default header.b=OCcq8zZf; spf=pass (google.com: domain of lmark@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=lmark@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 15A7A60328 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=lmark@codeaurora.org Date: Mon, 22 Jan 2018 08:52:57 -0800 (PST) From: Liam Mark X-X-Sender: lmark@lmark-linux.qualcomm.com To: Greg KH cc: Laura Abbott , Sumit Semwal , linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: android: ion: Zero CMA allocated memory In-Reply-To: <20180120080008.GA20172@kroah.com> Message-ID: References: <20180120080008.GA20172@kroah.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1590312283457758303?= X-GMAIL-MSGID: =?utf-8?q?1590312283457758303?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sat, 20 Jan 2018, Greg KH wrote: > On Fri, Jan 19, 2018 at 11:16:47AM -0800, Liam Mark wrote: > > Since the CMA API is now used directly the allocated memory is no longer > > automatically zeroed. > > > > Explicitly zero CMA allocated memory to ensure that no data is exposed > > to userspace. > > How far back does this patch need to be ported? What is the git commit > id that caused this change to be needed? Please add it as a "Fixes:" > tag to the patch. > It goes back to 204f672255c2 ("ion: Use CMA APIs directly"), I will update the change. > > > > Change-Id: I08e143707a0d31610821a7f16826c262bf3c1999 > > I'm guessing you didn't run scripts/checkpatch.pl on this patch :( > > Please fix up and resend. Thanks, I will clean it up. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project