From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225wUoQfWVCwBlnk1uq4JGoimy0lSZmvnhaslpHkXTXaJe1bZPQ2a0QbgwTqmnqAtbDEjnXd ARC-Seal: i=1; a=rsa-sha256; t=1516643203; cv=none; d=google.com; s=arc-20160816; b=lN1H3Ma3ZjEmCYQT/PHV/tBnezixl8/QJdnk/z1SIexHFDbB4gbNFdPre4hc9u66m0 2IQRNhsSbpY1iKh7rUXvolz4nDp1nYBf4Nx5zy8PrPyvNimNObDEJTvySPlgD9OK3x4P bnUMi3PGSagLAkpj0Klr4UvRL7hL8qAD7b/Kk9JHgOlGK9AR7zg1N04CI50PAsVUu5E9 KT7Q0OfmiMGETgXkZ16EFdRVIjnT/zbxTU92P7wmvW4LnmkQq2S/1WJnWzjSCH42EmWH b9IB6wx9Iv/TBPfnJ/9V+RyYW5+6Mnp0ziw/NUj/M3kJKN7yDoRub2hQ5r8uRBW7lGNE PhPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:message-id:subject:cc:to:from:date :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=whojupztqoHouOhXljPtYBp1d3E0xuA/z1762WonjOU=; b=aOFkcTnTkWZAESrofNxNeo1tuCruxz6KvNR2dc+5goLjNi5iHTVUJWQ3KaSiO0SIxc llagtA7rgK4gRXkGzvOW/QDOgUOqxZ/hMNKJFwXECwDVCF+p9skYDo4wBrrQswTQgaP5 VNeGOutY3Kvr/apIA5218+JF52msEQnWgAg9g+UKAYcCPi20jLI4gb33H53sIoCSYsvF rSGghsHG/snnSC9YiMLV3vhRol25vk5ZHncy6uPY9eid6C79M6dwTcjy7KTtpRCdC9CS il+msEIpS75b0OQr8c8XIlFUIm3zhBQtDAJmBQtgwbKAu0BGpWe/cNFQJsy4cMyieKvT pE1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QpwQDTS3; dkim=pass header.i=@codeaurora.org header.s=default header.b=MOM5ldM7; spf=pass (google.com: domain of lmark@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=lmark@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QpwQDTS3; dkim=pass header.i=@codeaurora.org header.s=default header.b=MOM5ldM7; spf=pass (google.com: domain of lmark@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=lmark@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6274E6021C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=lmark@codeaurora.org Date: Mon, 22 Jan 2018 09:46:41 -0800 (PST) From: Liam Mark X-X-Sender: lmark@lmark-linux.qualcomm.com To: Laura Abbott , Sumit Semwal cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Dan Carpenter , Greg KH , linaro-mm-sig@lists.linaro.org Subject: [PATCH v2] staging: android: ion: Zero CMA allocated memory Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1590312283457758303?= X-GMAIL-MSGID: =?utf-8?q?1590315664056456234?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly") the CMA API is now used directly and therefore the allocated memory is no longer automatically zeroed. Explicitly zero CMA allocated memory to ensure that no data is exposed to userspace. Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly") Signed-off-by: Liam Mark --- Changes in v2: - Clean up the commit message. - Add 'Fixes:' drivers/staging/android/ion/ion_cma_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c index 86196ffd2faf..91a98785607a 100644 --- a/drivers/staging/android/ion/ion_cma_heap.c +++ b/drivers/staging/android/ion/ion_cma_heap.c @@ -51,6 +51,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, if (!pages) return -ENOMEM; + memset(page_address(pages), 0, size); + table = kmalloc(sizeof(*table), GFP_KERNEL); if (!table) goto err; -- 1.8.5.2 Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project