From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2673164-1516840835-2-12664927580477140298 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.137', Host='smtp4.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516840835; b=KxSFRk4PW4v0G5uvYbz5dPuZVk4XsbytakoZyCjxq5P14yH xD8X1pwBt5JOyXLuYUj1EuSze6Q6oynxbuPg0Ewdvgxyh+syL4JmFnun6LA057Sh IA5YBjYfVDqpc0LZPNkUuYJM3+t8gC43INZIX6F9IrOoJMkSF47/uZuZn9qqMZfV Ja4NQ9rc+mQIniwo4CAzgflueNPYsXRciTXCjlP4SDZkYPgWDaJZ6k5BrQWbiXgO iEk/Xqke5dnIwDv+FeqV6kIlhOGMZ5bcCdhqa0gIl1Xu4RN6Bd2GQtLMm3KRfW8D ZcxrJh4JNFW7pQhJ+TtG2XRqPF3kkJfjfDPj9WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:in-reply-to :message-id:references:mime-version:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516840835; bh=5 5KPJsdBYr2GxGW57khWm8wHnvOe11yFsQK5wjbFgRI=; b=Fw9rM3fd4rhfL7LMB NU4oT/xtcLqkHpLgozhGa3bX4vKEF0wqGhNI9VPn4HTBMNde1/QBfVHnESp0VmYu FvWktypAWYxp+84yMqEcmHXgi3Tb7XXDFKjR7zbK4WjLY0zqGJ6z/20a1hAoeH/J xsmiDMHKIAYJ1mA3SZrsk7C71o5WUvo5PjEJR9nSY/KY0Yb2TLgkQXkiihVwYKwi 11IEqyGdIJ5LqP2nzZeWY0UpIHaeV4s8eZH42OlZsM7f5seUEiv3yhAoJZLeUATf mwCdXfVc1ug3JQkgZFq3jz7+Hdx6zTna0p3nXB/H1HyRL7jb4rtRWmgLllhRD1Nn e10Rg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=TLhZUUS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dkim=fail (message has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=TLhZUUS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=codeaurora.org; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=codeaurora.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=TLhZUUS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dkim=fail (message has been altered; 1024-bit rsa key sha256) header.d=codeaurora.org header.i=@codeaurora.org header.b=TLhZUUS9 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=default; dmarc=none (p=none,has-list-id=yes,d=none) header.from=codeaurora.org; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=codeaurora.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B6FF66074E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=lmark@codeaurora.org Date: Wed, 24 Jan 2018 16:40:27 -0800 (PST) From: Liam Mark X-X-Sender: lmark@lmark-linux.qualcomm.com To: Laura Abbott Subject: Re: [PATCH v2] staging: android: ion: Zero CMA allocated memory In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg KH , linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Sumit Semwal , Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, 24 Jan 2018, Laura Abbott wrote: > On 01/22/2018 09:46 AM, Liam Mark wrote: > > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly") > > the CMA API is now used directly and therefore the allocated memory is no > > longer automatically zeroed. > > > > Explicitly zero CMA allocated memory to ensure that no data is exposed to > > userspace. > > > > Fixes: 204f672255c2 ("staging: android: ion: Use CMA APIs directly") > > Signed-off-by: Liam Mark > > --- > > Changes in v2: > > - Clean up the commit message. > > - Add 'Fixes:' > > > > drivers/staging/android/ion/ion_cma_heap.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c > > b/drivers/staging/android/ion/ion_cma_heap.c > > index 86196ffd2faf..91a98785607a 100644 > > --- a/drivers/staging/android/ion/ion_cma_heap.c > > +++ b/drivers/staging/android/ion/ion_cma_heap.c > > @@ -51,6 +51,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct > > ion_buffer *buffer, > > if (!pages) > > return -ENOMEM; > > > > + memset(page_address(pages), 0, size); > > + > > This won't work for highmem pages. You need to zero by page via > kmap_atomic in that case. You can use PageHighMem to separate the > paths. Thanks for catching that, I will update the patch. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel