mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nate Eldredge <nate@thatsmathematics.com>
To: George Spelvin <linux@horizon.com>
Cc: adilger@dilger.ca, arjan@linux.intel.com, jack@suse.cz,
	linux-kernel@vger.kernel.org, maarten-baert@hotmail.com,
	mingo@elte.hu, suresh.b.siddha@intel.com, tglx@linutronix.de,
	viro@zeniv.linux.org.uk
Subject: Re: math_state_restore and kernel_fpu_end disable interrupts?
Date: Mon, 20 Jan 2014 19:22:51 -0700 (MST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1401201915250.2663@minerva.lan> (raw)
In-Reply-To: <20140119210228.9598.qmail@science.horizon.com>

On Sun, 19 Jan 2014, George Spelvin wrote:

>> It's credited to Suresh Siddha, whom I've cc'ed (along with others who
>> signed off).  Suresh, if you're still around, could you comment on why
>> math_state_restore always leaves interrupts disabled, regardless of their
>> state on entry?  Is there a deep reason or is it a bug?
>
> What the comments seemed to be implying was that it was a bug to enter
> this code with interrupts enabled.  So the problem may be a little bit
> more systemic; expert counsel is required.

It would be kind of weird for code that requires disabled interrupts on 
entry to turn around and enable interrupts itself.  I agree that it would 
really help for a guru to take a look...

On which note, Suresh's email bounced :-(

-- 
Nate Eldredge
nate@thatsmathematics.com


  reply	other threads:[~2014-01-21  2:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-19 11:35 George Spelvin
2014-01-19 19:02 ` Nate Eldredge
2014-01-19 21:02   ` George Spelvin
2014-01-21  2:22     ` Nate Eldredge [this message]
2014-01-21 13:58       ` Jan Kara
2014-01-21 17:10       ` George Spelvin
2014-01-28 18:53     ` George Spelvin
2014-01-28 19:23       ` Nate Eldredge
  -- strict thread matches above, loose matches on Subject: below --
2014-01-18  6:15 Nate Eldredge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1401201915250.2663@minerva.lan \
    --to=nate@thatsmathematics.com \
    --cc=adilger@dilger.ca \
    --cc=arjan@linux.intel.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=maarten-baert@hotmail.com \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®