From: Thomas Pugliese <thomas.pugliese@gmail.com>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: gregkh@linuxfoundation.org, ly80toro@cip.cs.fau.de,
alan@linux.intel.com, linux-usb@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com
Subject: Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array
Date: Fri, 24 Jan 2014 11:08:49 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.10.1401241106380.28215@mint32-virtualbox> (raw)
In-Reply-To: <1390420383-3933-1-git-send-email-shuah.kh@samsung.com>
On Wed, 22 Jan 2014, Shuah Khan wrote:
> Add speed strings for usb wireless and 3.0 to speed_strings array.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> index 66f03cc..8cb4fcc 100644
> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c
> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = {
> { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" },
> { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" },
> { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" },
> + { USB_SPEED_WIRELESS, "2.5", "Wireless"},
> + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" },
> { 0, NULL, NULL }
> };
>
> --
Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not
sure how you want to represent that but "2.5" doesn't seem to apply.
Thanks,
Thomas
next prev parent reply other threads:[~2014-01-24 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 19:53 Shuah Khan
2014-01-24 17:08 ` Thomas Pugliese [this message]
2014-01-24 17:12 ` Shuah Khan
2014-01-24 17:31 ` Thomas Pugliese
2014-01-24 17:38 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1401241106380.28215@mint32-virtualbox \
--to=thomas.pugliese@gmail.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ly80toro@cip.cs.fau.de \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®