From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbaAXRbt (ORCPT ); Fri, 24 Jan 2014 12:31:49 -0500 Received: from mail-oa0-f43.google.com ([209.85.219.43]:55524 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbaAXRbr (ORCPT ); Fri, 24 Jan 2014 12:31:47 -0500 Date: Fri, 24 Jan 2014 11:31:41 -0600 (CST) From: Thomas Pugliese To: Shuah Khan cc: Thomas Pugliese , gregkh@linuxfoundation.org, ly80toro@cip.cs.fau.de, alan@linux.intel.com, linux-usb@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, shuahkhan@gmail.com Subject: Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array In-Reply-To: <52E29F04.2070106@samsung.com> Message-ID: References: <1390420383-3933-1-git-send-email-shuah.kh@samsung.com> <52E29F04.2070106@samsung.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2014, Shuah Khan wrote: > On 01/24/2014 10:08 AM, Thomas Pugliese wrote: > > > > > > On Wed, 22 Jan 2014, Shuah Khan wrote: > > > > > Add speed strings for usb wireless and 3.0 to speed_strings array. > > > > > > Signed-off-by: Shuah Khan > > > --- > > > drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c > > > b/drivers/staging/usbip/userspace/libsrc/usbip_common.c > > > index 66f03cc..8cb4fcc 100644 > > > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c > > > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c > > > @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = { > > > { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" }, > > > { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" }, > > > { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" }, > > > + { USB_SPEED_WIRELESS, "2.5", "Wireless"}, > > > + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" }, > > > { 0, NULL, NULL } > > > }; > > > > > > -- > > > > Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not > > sure how you want to represent that but "2.5" doesn't seem to apply. > > > > Would "variable" be better suited in this case? > Sure. You could also use something like "53.3-480" since that would more closely match the other entires which are numerical values in Mbps units. Thomas