From: Christoph Lameter <cl@linux.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
penberg@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] slub: Do not assert not having lock in removing freed partial
Date: Thu, 6 Feb 2014 09:36:40 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.10.1402060936140.31869@nuc> (raw)
In-Reply-To: <52F32F46.8090205@parallels.com>
On Thu, 6 Feb 2014, Vladimir Davydov wrote:
> > @@ -2906,12 +2916,10 @@ static void early_kmem_cache_node_alloc(
> > inc_slabs_node(kmem_cache_node, node, page->objects);
> >
> > /*
> > - * the lock is for lockdep's sake, not for any actual
> > - * race protection
> > + * No locks need to be taken here as it has just been
> > + * initialized and there is no concurrent access.
> > */
> > - spin_lock(&n->list_lock);
> > - add_partial(n, page, DEACTIVATE_TO_HEAD);
> > - spin_unlock(&n->list_lock);
> > + __add_partial(n, page, DEACTIVATE_TO_HEAD);
> > }
Ahh.. Much better.
Acked-by: Christoph Lameter <cl@linux.com>
prev parent reply other threads:[~2014-02-06 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 3:21 Steven Rostedt
2014-02-06 4:05 ` David Rientjes
2014-02-06 6:44 ` Vladimir Davydov
2014-02-06 15:36 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1402060936140.31869@nuc \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®