From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756929AbaC0QK6 (ORCPT ); Thu, 27 Mar 2014 12:10:58 -0400 Received: from qmta03.emeryville.ca.mail.comcast.net ([76.96.30.32]:39703 "EHLO qmta03.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643AbaC0QK4 (ORCPT ); Thu, 27 Mar 2014 12:10:56 -0400 Date: Thu, 27 Mar 2014 11:10:53 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@nuc To: Mitchel Humpherys cc: Pekka Enberg , Matt Mackall , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: convert some level-less printks to pr_* In-Reply-To: Message-ID: References: <1395877783-18910-1-git-send-email-mitchelh@codeaurora.org> <1395877783-18910-2-git-send-email-mitchelh@codeaurora.org> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Would like to retracting the ack after seeing the other comments. Will ack after then issues have been fixed. On Wed, 26 Mar 2014, Christoph Lameter wrote: > On Wed, 26 Mar 2014, Mitchel Humpherys wrote: > > > printk is meant to be used with an associated log level. There are some > > instances of printk scattered around the mm code where the log level is > > missing. Add a log level and adhere to suggestions by > > scripts/checkpatch.pl by moving to the pr_* macros. > > Acked-by: Christoph Lameter > >