From: Thomas Gleixner <tglx@linutronix.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Zhouyi Zhou <zhouzhouyi@gmail.com>,
mingo@redhat.com, x86@kernel.org, peterz@infradead.org,
cpw@sgi.com, linux-kernel@vger.kernel.org,
Zhouyi Zhou <yizhouzhou@ict.ac.cn>
Subject: Re: [PATCH] x86/tlb_uv: Fixing some memory allocation failure in x86 UV
Date: Wed, 11 Jun 2014 01:28:02 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1406110111300.5170@nanos> (raw)
In-Reply-To: <53978E9F.1010003@zytor.com>
On Tue, 10 Jun 2014, H. Peter Anvin wrote:
> On 06/10/2014 12:35 AM, Zhouyi Zhou wrote:
> > Fixing some memory allocation failure handling in x86 UV
> >
> > Signed-off-by: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
>
> Sorry, this really isn't enough description for this size of a patch.
Correction: This is not a proper description for any patch.
"some" is wrong to begin with.
Either we fix a particular issue or we address all of them, but "some"
means: We fixed a few, but we did not care about the rest.
Aside of that, I agree. The changelog is disjunct from the patch
itself.
Thanks,
tglx
next prev parent reply other threads:[~2014-06-10 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 7:35 Zhouyi Zhou
2014-06-10 23:02 ` H. Peter Anvin
2014-06-10 23:28 ` Thomas Gleixner [this message]
2014-06-11 1:46 ` Zhouyi Zhou
2014-06-11 2:50 ` Joe Perches
2014-06-10 23:27 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1406110111300.5170@nanos \
--to=tglx@linutronix.de \
--cc=cpw@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
--cc=yizhouzhou@ict.ac.cn \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®