From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965754AbaFTHwj (ORCPT ); Fri, 20 Jun 2014 03:52:39 -0400 Received: from www.linutronix.de ([62.245.132.108]:57253 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794AbaFTHwi (ORCPT ); Fri, 20 Jun 2014 03:52:38 -0400 Date: Fri, 20 Jun 2014 09:52:33 +0200 (CEST) From: Thomas Gleixner To: Viresh Kumar cc: LKML , Rob Herring , devicetree@vger.kernel.org, spear-devel Subject: Re: [patch 2/2] dts: spear: Add missing i2c1 interrupt In-Reply-To: Message-ID: References: <20140619215347.139324048@linutronix.de> <20140619215557.875556819@linutronix.de> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jun 2014, Viresh Kumar wrote: > On Fri, Jun 20, 2014 at 3:26 AM, Thomas Gleixner wrote: > > Signed-off-by: Thomas Gleixner > > --- > > arch/arm/boot/dts/spear320.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > Index: linux/arch/arm/boot/dts/spear320.dtsi > > =================================================================== > > --- linux.orig/arch/arm/boot/dts/spear320.dtsi > > +++ linux/arch/arm/boot/dts/spear320.dtsi > > @@ -123,6 +123,11 @@ > > status = "disabled"; > > }; > > > > + i2c1: i2c@a7000000 { > > + interrupts = <21>; > > + interrupt-parent = <&shirq>; > > + }; > > Isn't this already available ? > > i2c1: i2c@a7000000 { > #address-cells = <1>; > #size-cells = <0>; > compatible = "snps,designware-i2c"; > reg = <0xa7000000 0x1000>; > interrupts = <21>; > interrupt-parent = <&shirq>; > status = "disabled"; > }; Oops yes, did this against an older tree and did not notice the duplicate. So nothing to do here. Thanks, tglx