From: Thomas Gleixner <tglx@linutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mike Turquette <mturquette@linaro.org>,
spear-devel <spear-devel@list.st.com>
Subject: Re: [patch 2/2] clk: spear3xx: Set proper clock parent of uart1/2
Date: Fri, 20 Jun 2014 09:53:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1406200952580.5170@nanos> (raw)
In-Reply-To: <CAOh2x=niR4_jtWL2VRvZJ8LKkmW4fyNXB9+UzUKeRSagdm1xFw@mail.gmail.com>
On Fri, 20 Jun 2014, Viresh Kumar wrote:
> On Fri, Jun 20, 2014 at 3:22 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > The uarts only work when the parent is ras_ahb_clk. The stale 3.5
> > based ST tree does this in the board file.
> >
> > Add it to the clk init function. Not pretty, but the mess there is
> > amazing anyway.
>
> I still feel that board file is the right place to do it. Similar stuff might be
> required for some other peripheral clocks later and this solution
> wouldn't be scalable then.
>
> But if you insist on doing it this way:
I really do not care much as long as it works.
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
next prev parent reply other threads:[~2014-06-20 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 21:52 [patch 0/2] clk: spear3xx: Make it actually work Thomas Gleixner
2014-06-19 21:52 ` [patch 1/2] clk: spear3xx: Use proper control register offset Thomas Gleixner
2014-06-20 4:51 ` Viresh Kumar
2014-06-19 21:52 ` [patch 2/2] clk: spear3xx: Set proper clock parent of uart1/2 Thomas Gleixner
2014-06-20 5:41 ` Viresh Kumar
2014-06-20 7:53 ` Thomas Gleixner [this message]
2014-07-13 14:12 ` [patch 0/2] clk: spear3xx: Make it actually work Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1406200952580.5170@nanos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®