From: Thomas Gleixner <tglx@linutronix.de>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: daniel.lezcano@linaro.org, dongsheng.wang@freescale.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.
Date: Wed, 3 Sep 2014 12:38:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1409031236450.3333@nanos> (raw)
In-Reply-To: <1409031951-39021-3-git-send-email-Li.Xiubo@freescale.com>
On Tue, 26 Aug 2014, Xiubo Li wrote:
> Since the Flextimer device will be implemented in BE mode on
> LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need
> the endianness judgment before doing the mmio.
Brilliant. So for every clocksource read you take a conditional.
> @@ -238,7 +243,7 @@ static int __init ftm_clocksource_init(unsigned long freq)
> sched_clock_register(ftm_read_sched_clock, 16, freq / (1 << priv->ps));
> err = clocksource_mmio_init(priv->clksrc_base + FTM_CNT, "fsl-ftm",
> freq / (1 << priv->ps), 300, 16,
> - clocksource_mmio_readl_up);
> + ftm_clocksource_read_up);
What's wrong with having endianess aware clocksource_mmio functions
and make the decision at init time?
Thanks
tglx
next prev parent reply other threads:[~2014-09-03 10:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 5:45 [PATCH 0/5] Clocksource: Flextimer: Merged to LS1 Xiubo Li
2014-08-26 5:45 ` [PATCH 1/5] Clocksource: Flextimer: Set cpumask to cpu_possible_mask Xiubo Li
2014-08-26 5:45 ` [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API Xiubo Li
2014-09-03 10:38 ` Thomas Gleixner [this message]
2014-09-04 1:49 ` Li.Xiubo
2014-09-04 8:35 ` Thomas Gleixner
2014-09-04 8:43 ` Li.Xiubo
2014-09-04 8:45 ` Thomas Gleixner
2014-09-04 8:53 ` Li.Xiubo
2014-09-05 5:59 ` Li.Xiubo
2014-08-26 5:45 ` [PATCH 3/5] Clocksource: Flextimer: Remove the useless code Xiubo Li
2014-08-26 5:45 ` [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation Xiubo Li
2014-09-03 10:57 ` Thomas Gleixner
2014-09-04 2:18 ` Li.Xiubo
2014-09-03 10:59 ` Thomas Gleixner
2014-09-04 2:03 ` Li.Xiubo
2014-08-26 5:45 ` [PATCH 5/5] Clocksource: Flextimer: Use Macro for clock source selection Xiubo Li
2014-09-03 12:01 ` Thomas Gleixner
2014-09-04 2:06 ` Li.Xiubo
2014-09-04 8:36 ` Thomas Gleixner
2014-09-03 3:50 ` [PATCH 0/5] Clocksource: Flextimer: Merged to LS1 Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1409031236450.3333@nanos \
--to=tglx@linutronix.de \
--cc=Li.Xiubo@freescale.com \
--cc=daniel.lezcano@linaro.org \
--cc=dongsheng.wang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®