From: Thomas Gleixner <tglx@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net,
computersforpeace@gmail.com
Subject: Re: [PATCH 1/2] irqchip: add Broadcom BCM7120-style Level 2 interrupt controller
Date: Wed, 3 Sep 2014 14:18:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1409031413230.3333@nanos> (raw)
In-Reply-To: <1409265326-7579-2-git-send-email-f.fainelli@gmail.com>
On Thu, 28 Aug 2014, Florian Fainelli wrote:
> +static void bcm7120_l2_intc_irq_handle(unsigned int irq, struct irq_desc *desc)
> +{
> + struct bcm7120_l2_intc_data *b = irq_desc_get_handler_data(desc);
> + struct irq_chip *chip = irq_desc_get_chip(desc);
> + struct irq_chip_generic *gc = irq_get_domain_generic_chip(b->domain, 0);
> + u32 status;
> +
> + chained_irq_enter(chip, desc);
> +
> + irq_gc_lock(gc);
> + status = __raw_readl(b->base + IRQSTAT);
> + irq_gc_unlock(gc);
Why do you need locking around the status read out?
> + for (irq = 0; irq < num_parent_irqs; irq++) {
> + ret = bcm7120_l2_intc_init_one(dn, data, irq, map_mask);
> + if (ret)
> + continue;
What's the exact purpose of this "if (ret)" construct?
Thanks,
tglx
next prev parent reply other threads:[~2014-09-03 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 22:35 [PATCH 0/2] irqchip: " Florian Fainelli
2014-08-28 22:35 ` [PATCH 1/2] irqchip: add " Florian Fainelli
2014-09-03 12:18 ` Thomas Gleixner [this message]
2014-09-03 16:39 ` Florian Fainelli
2014-08-28 22:35 ` [PATCH 2/2] Documentation: bcm7120-l2: Add Broadcom BCM7120-style L2 binding Florian Fainelli
2014-09-03 12:13 ` Thomas Gleixner
2014-09-03 12:43 ` Mark Rutland
2014-09-03 16:59 ` Florian Fainelli
2014-09-05 9:05 ` Mark Rutland
2014-09-05 18:01 ` Florian Fainelli
2014-09-05 19:21 ` Thomas Gleixner
2014-09-05 19:57 ` Florian Fainelli
2014-09-05 20:44 ` Thomas Gleixner
2014-09-05 21:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1409031413230.3333@nanos \
--to=tglx@linutronix.de \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®