From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756661AbaIQTFs (ORCPT ); Wed, 17 Sep 2014 15:05:48 -0400 Received: from www.linutronix.de ([62.245.132.108]:50892 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755907AbaIQTFr (ORCPT ); Wed, 17 Sep 2014 15:05:47 -0400 Date: Wed, 17 Sep 2014 12:05:42 -0700 (PDT) From: Thomas Gleixner To: Eric Caruso cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org, Benson Leung , Dmitry Torokhov Subject: Re: irq mask swapping during suspend/resume In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Sep 2014, Eric Caruso wrote: > We would like to be able to set different irq masks for triggers during > normal operation and for waking up the system. For example, while a laptop > is awake, closing the lid and opening the lid should both fire an > interrupt, but when the system is asleep, we would like to stay asleep when > closing the lid. > > We are thinking about stashing the irq mask used specifically for waking > the system up in the irq_desc struct, and then swapping it during > enable_irq_wake and disable_irq_wake calls. Devices that do not specify a > different wake mask will use their normal trigger mask for both situations. > > Is this acceptable? Not really. Why should irq_desc provide storage for random configurations and bind them to some random system state? What's wrong with calling irq_set_type(irq, B); enable_irq_wake(irq); disable_irq_wake(irq); irq_set_type(irq, A); ???? Thanks, tglx