From: Julia Lawall <julia.lawall@lip6.fr>
To: "Drokin, Oleg" <oleg.drokin@intel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"<kernel-janitors@vger.kernel.org>"
<kernel-janitors@vger.kernel.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
"<HPDD-discuss@ml01.01.org>" <HPDD-discuss@ml01.01.org>
Subject: Re: [HPDD-discuss] [PATCH] staging: lustre: llite: Use kzalloc and rewrite null tests
Date: Fri, 19 Sep 2014 06:45:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1409190637190.2507@hadrien> (raw)
In-Reply-To: <517B3353-BD3C-4326-A8F4-F1775B4865E5@intel.com>
With respect to the upper case lower case issue, does the thing need to be
a macro? I think that the lowercase is more or less fine, but only if
what is behind it is a function.
I say more or less fine, because normally in the kernel the special
allocators have special purposes, eg allocating and initializing the xyz
structure. Here what is wanted is a general purpose allocator with lots
of special tracing features, so it is not quite the same thing. And one
can wonder why all of these special tracing features are not relevant to
the kernel as a whole?
In reading through the description of the needed features, it seems like
only the _ptr extension requires being a macro. Do we need that? The
rest of the kernel manages to do x = kzalloc(sizeof(*x),...) ok. It's
unpleasant to have an assignment hidden in this way. And currently it is
not used consistently. There are some OBD_ALLOCs that have the same form.
Sorry for overlooking the frees. I was focusing on trying one thing at a
time...
julia
next prev parent reply other threads:[~2014-09-19 4:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 20:24 [PATCH] " Julia Lawall
2014-09-18 20:24 ` [PATCH] staging: lustre: llite: " Julia Lawall
2014-09-18 23:43 ` Dan Carpenter
2014-09-19 2:57 ` Drokin, Oleg
2014-09-19 3:04 ` [HPDD-discuss] " Drokin, Oleg
2014-09-19 4:45 ` Julia Lawall [this message]
2014-09-19 13:36 ` Drokin, Oleg
2014-09-19 13:50 ` Julia Lawall
2014-09-19 9:11 ` Dan Carpenter
2014-09-19 13:27 ` Drokin, Oleg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1409190637190.2507@hadrien \
--to=julia.lawall@lip6.fr \
--cc=HPDD-discuss@ml01.01.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®