mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Dan Mick <dan.mick@inktank.com>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <mmarek@suse.cz>,
	cocci@systeme.lip6.fr
Subject: Re: [PATCH 1/1 linux-next] scripts/coccinelle/misc/boolinit.cocci: fix assignment warnings
Date: Fri, 10 Oct 2014 09:55:16 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1410100954590.2402@hadrien> (raw)
In-Reply-To: <1412925511-3556-1-git-send-email-fabf@skynet.be>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Thanks!

On Fri, 10 Oct 2014, Fabian Frederick wrote:

> Replace "Assignment of bool to 0/1" by "Assignment of 0/1 to bool"
>
> Suggested-by: Dan Mick <dan.mick@inktank.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  scripts/coccinelle/misc/boolinit.cocci | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/boolinit.cocci b/scripts/coccinelle/misc/boolinit.cocci
> index b9abed4..63c4562 100644
> --- a/scripts/coccinelle/misc/boolinit.cocci
> +++ b/scripts/coccinelle/misc/boolinit.cocci
> @@ -145,13 +145,13 @@ cocci.print_main("WARNING: Comparison of bool to 0/1",p)
>  p1 << r3.p1;
>  @@
>
> -cocci.print_main("WARNING: Assignment of bool to 0/1",p1)
> +cocci.print_main("WARNING: Assignment of 0/1 to bool",p1)
>
>  @script:python depends on org@
>  p2 << r3.p2;
>  @@
>
> -cocci.print_main("ERROR: Assignment of bool to non-0/1 constant",p2)
> +cocci.print_main("ERROR: Assignment of non-0/1 constant to bool",p2)
>
>  @script:python depends on report@
>  p << r1.p;
> @@ -169,10 +169,10 @@ coccilib.report.print_report(p[0],"WARNING: Comparison of bool to 0/1")
>  p1 << r3.p1;
>  @@
>
> -coccilib.report.print_report(p1[0],"WARNING: Assignment of bool to 0/1")
> +coccilib.report.print_report(p1[0],"WARNING: Assignment of 0/1 to bool")
>
>  @script:python depends on report@
>  p2 << r3.p2;
>  @@
>
> -coccilib.report.print_report(p2[0],"ERROR: Assignment of bool to non-0/1 constant")
> +coccilib.report.print_report(p2[0],"ERROR: Assignment of non-0/1 constant to bool")
> --
> 1.9.3
>
>

      reply	other threads:[~2014-10-10  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  7:18 Fabian Frederick
2014-10-10  7:55 ` Julia Lawall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1410100954590.2402@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=dan.mick@inktank.com \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome