mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SeongJae Park <sj38.park@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: SeongJae Park <sj38.park@gmail.com>,
	tj@kernel.org, lizefan@huawei.com, trivial@kernel.org,
	cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cgroups: Documentation: fix trivial typos and wrong paragraph numberings
Date: Thu, 4 Dec 2014 00:36:09 +0900 (KST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1412040033120.1819@hxeon> (raw)
In-Reply-To: <20141203090113.359198f6@lwn.net>



On Wed, 3 Dec 2014, Jonathan Corbet wrote:

> On Wed,  3 Dec 2014 20:53:45 +0900
> SeongJae Park <sj38.park@gmail.com> wrote:
>
>>  Documentation/cgroups/cpusets.txt | 6 +++---
>>  Documentation/cgroups/memory.txt  | 8 ++++----
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> I applied patch 1 to my docs tree, but this one doesn't apply.  Which
> kernel did you base it on?

I based it on latest linux-next tree.

Looks like I should based it on linux-docs tree. I will do for my later 
patches for documentations.

Below is the patch 2 based on linux-docs tree.


========================= >3 ===================================

>From 6f0abd850dfdc4ca06a29e62a268b5c8da931053 Mon Sep 17 00:00:00 2001
From: SeongJae Park <sj38.park@gmail.com>
Date: Wed, 3 Dec 2014 20:45:48 +0900
Subject: [PATCH] cgroups: Documentation: fix trivial typos and wrong 
paragraph
  numberings

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
  Documentation/cgroups/cpusets.txt | 6 +++---
  Documentation/cgroups/memory.txt  | 8 ++++----
  2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/cgroups/cpusets.txt 
b/Documentation/cgroups/cpusets.txt
index 7740038..2e921b5 100644
--- a/Documentation/cgroups/cpusets.txt
+++ b/Documentation/cgroups/cpusets.txt
@@ -445,7 +445,7 @@ across partially overlapping sets of CPUs would risk 
unstable dynamics
  that would be beyond our understanding.  So if each of two partially
  overlapping cpusets enables the flag 'cpuset.sched_load_balance', then we
  form a single sched domain that is a superset of both.  We won't move
-a task to a CPU outside it cpuset, but the scheduler load balancing
+a task to a CPU outside its cpuset, but the scheduler load balancing
  code might waste some compute cycles considering that possibility.

  This mismatch is why there is not a simple one-to-one relation
@@ -552,8 +552,8 @@ otherwise initial value -1 that indicates the cpuset 
has no request.
     1  : search siblings (hyperthreads in a core).
     2  : search cores in a package.
     3  : search cpus in a node [= system wide on non-NUMA system]
- ( 4  : search nodes in a chunk of node [on NUMA system] )
- ( 5  : search system wide [on NUMA system] )
+   4  : search nodes in a chunk of node [on NUMA system]
+   5  : search system wide [on NUMA system]

  The system default is architecture dependent.  The system default
  can be changed using the relax_domain_level= boot parameter.
diff --git a/Documentation/cgroups/memory.txt 
b/Documentation/cgroups/memory.txt
index 02ab997..228c1cc 100644
--- a/Documentation/cgroups/memory.txt
+++ b/Documentation/cgroups/memory.txt
@@ -321,7 +321,7 @@ per cgroup, instead of globally.

  * tcp memory pressure: sockets memory pressure for the tcp protocol.

-2.7.3 Common use cases
+2.7.2 Common use cases

  Because the "kmem" counter is fed to the main user counter, kernel memory 
can
  never be limited completely independently of user memory. Say "U" is the 
user
@@ -349,7 +349,7 @@ set:

  3. User Interface

-0. Configuration
+3.0. Configuration

  a. Enable CONFIG_CGROUPS
  b. Enable CONFIG_RESOURCE_COUNTERS
@@ -357,12 +357,12 @@ c. Enable CONFIG_MEMCG
  d. Enable CONFIG_MEMCG_SWAP (to use swap extension)
  d. Enable CONFIG_MEMCG_KMEM (to use kmem extension)

-1. Prepare the cgroups (see cgroups.txt, Why are cgroups needed?)
+3.1. Prepare the cgroups (see cgroups.txt, Why are cgroups needed?)
  # mount -t tmpfs none /sys/fs/cgroup
  # mkdir /sys/fs/cgroup/memory
  # mount -t cgroup none /sys/fs/cgroup/memory -o memory

-2. Make the new group and move bash into it
+3.2. Make the new group and move bash into it
  # mkdir /sys/fs/cgroup/memory/0
  # echo $$ > /sys/fs/cgroup/memory/0/tasks

--
1.9.1


Thanks,
SeongJae Park

>
> Thanks,
>
> jon
>

  reply	other threads:[~2014-12-03 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 11:53 [PATCH 1/2] cgroups: Documentation: fix wrong cgroupfs paths SeongJae Park
2014-12-03 11:53 ` [PATCH 2/2] cgroups: Documentation: fix trivial typos and wrong paragraph numberings SeongJae Park
2014-12-03 14:01   ` Jonathan Corbet
2014-12-03 15:36     ` SeongJae Park [this message]
2014-12-03 16:43       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1412040033120.1819@hxeon \
    --to=sj38.park@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®