From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754412AbbBKUAR (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Feb 2015 15:00:17 -0500
Received: from mail-wi0-f176.google.com ([209.85.212.176]:54919 "EHLO
	mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754386AbbBKUAP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Feb 2015 15:00:15 -0500
Date: Wed, 11 Feb 2015 12:00:02 -0800 (PST)
From: David Rientjes <rientjes@google.com>
X-X-Sender: rientjes@chino.kir.corp.google.com
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Michel Lespinasse <walken@google.com>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 4/4] mm: move mm_populate()-related code to mm/gup.c
In-Reply-To: <1423674728-214192-5-git-send-email-kirill.shutemov@linux.intel.com>
Message-ID: <alpine.DEB.2.10.1502111158360.9656@chino.kir.corp.google.com>
References: <1423674728-214192-1-git-send-email-kirill.shutemov@linux.intel.com> <1423674728-214192-5-git-send-email-kirill.shutemov@linux.intel.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Feb 2015, Kirill A. Shutemov wrote:

> It's odd that we have populate_vma_page_range() and __mm_populate() in
> mm/mlock.c. It's implementation of generic memory population and
> mlocking is one of possible side effect, if VM_LOCKED is set.
> 
> __get_user_pages() is core of the implementation. Let's move the code
> mm/gup.c.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Acked-by: David Rientjes <rientjes@google.com>

Nice cleanup!