From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755785AbbCCEPw (ORCPT ); Mon, 2 Mar 2015 23:15:52 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:45102 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186AbbCCEPu (ORCPT ); Mon, 2 Mar 2015 23:15:50 -0500 Date: Mon, 2 Mar 2015 20:15:47 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Tapasweni Pathak cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, tglx@linutronix.de, ionut.m.alexa@gmail.com, paulmcquad@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel: Unlock after locking In-Reply-To: <20150303031910.GA25670@kt-Inspiron-3542> Message-ID: References: <20150303031910.GA25670@kt-Inspiron-3542> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Mar 2015, Tapasweni Pathak wrote: > diff --git a/kernel/acct.c b/kernel/acct.c > index e6c10d1a..f592218 100644 > --- a/kernel/acct.c > +++ b/kernel/acct.c > @@ -161,6 +161,7 @@ again: > acct_put(res); > goto again; > } > + mutex_unlock(&res->lock); > return res; > } > This function returns with the mutex held, the caller releases it.