From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754334AbbCDFym (ORCPT ); Wed, 4 Mar 2015 00:54:42 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:38148 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbbCDFyk (ORCPT ); Wed, 4 Mar 2015 00:54:40 -0500 Date: Tue, 3 Mar 2015 21:54:38 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: Leon Yu , Andrew Morton , Konstantin Khlebnikov , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: fix anon_vma->degree underflow in anon_vma endless growing prevention In-Reply-To: <20150303133642.GC2409@dhcp22.suse.cz> Message-ID: References: <1425384142-5064-1-git-send-email-chianglungyu@gmail.com> <20150303133642.GC2409@dhcp22.suse.cz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Mar 2015, Michal Hocko wrote: > I think we can safely remove the following code as well, because it is > anon_vma_clone which is responsible to do all the cleanups. > > diff --git a/mm/mmap.c b/mm/mmap.c > index 943c6ad18b1d..06a6076c92e5 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -774,10 +774,8 @@ again: remove_next = 1 + (end > next->vm_end); > > importer->anon_vma = exporter->anon_vma; > error = anon_vma_clone(importer, exporter); > - if (error) { > - importer->anon_vma = NULL; > + if (error) > return error; > - } > } > } > When Michal proposes this on top of -mm, feel free to add my Acked-by: David Rientjes