From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbbCFVHH (ORCPT ); Fri, 6 Mar 2015 16:07:07 -0500 Received: from mail-ig0-f171.google.com ([209.85.213.171]:46973 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbbCFVHE (ORCPT ); Fri, 6 Mar 2015 16:07:04 -0500 Date: Fri, 6 Mar 2015 13:07:02 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Eric B Munson cc: Andrew Morton , Vlastimil Babka , Thomas Gleixner , Christoph Lameter , Peter Zijlstra , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Allow compaction of unevictable pages In-Reply-To: <1425667287-30841-1-git-send-email-emunson@akamai.com> Message-ID: References: <1425667287-30841-1-git-send-email-emunson@akamai.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2015, Eric B Munson wrote: > diff --git a/mm/compaction.c b/mm/compaction.c > index 8c0d945..33c81e1 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1056,7 +1056,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, > { > unsigned long low_pfn, end_pfn; > struct page *page; > - const isolate_mode_t isolate_mode = > + const isolate_mode_t isolate_mode = ISOLATE_UNEVICTABLE | > (cc->mode == MIGRATE_ASYNC ? ISOLATE_ASYNC_MIGRATE : 0); > > /* I agree that memory compaction should be isolating and migrating unevictable memory for better results, and we have been running with a similar patch internally for about a year for the same purpose as you, higher probability of allocating hugepages. This would be better off removing the notion of ISOLATE_UNEVICTABLE entirely, however, since CMA and now memory compaction would be using it, so the check in __isolate_lru_page() is no longer necessary. Has the added bonus of removing about 10 lines of soure code.