From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752897AbbCZTan (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 15:30:43 -0400
Received: from mail-ig0-f170.google.com ([209.85.213.170]:36218 "EHLO
	mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752298AbbCZTak (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 15:30:40 -0400
Date: Thu, 26 Mar 2015 12:30:37 -0700 (PDT)
From: David Rientjes <rientjes@google.com>
X-X-Sender: rientjes@chino.kir.corp.google.com
To: Michal Hocko <mhocko@suse.cz>
cc: Johannes Weiner <hannes@cmpxchg.org>, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Huang Ying <ying.huang@intel.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Dave Chinner <david@fromorbit.com>, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [patch 01/12] mm: oom_kill: remove unnecessary locking in
 oom_enable()
In-Reply-To: <20150326131839.GI15257@dhcp22.suse.cz>
Message-ID: <alpine.DEB.2.10.1503261229350.9410@chino.kir.corp.google.com>
References: <1427264236-17249-1-git-send-email-hannes@cmpxchg.org> <1427264236-17249-2-git-send-email-hannes@cmpxchg.org> <alpine.DEB.2.10.1503251744290.32157@chino.kir.corp.google.com> <20150326115140.GC15257@dhcp22.suse.cz>
 <20150326131839.GI15257@dhcp22.suse.cz>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 26 Mar 2015, Michal Hocko wrote:

> I am wrong here! pagefault_out_of_memory takes the lock and so the whole
> mem_cgroup_out_of_memory is called under the same lock.

If all userspace processes are frozen by the time oom_killer_disable() is 
called, then there shouldn't be any race with the android lmk calling 
mark_tsk_oom_victim() either, so I assume that you're acking this patch?