From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbbC1Bhv (ORCPT ); Fri, 27 Mar 2015 21:37:51 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:33278 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbbC1Bht (ORCPT ); Fri, 27 Mar 2015 21:37:49 -0400 Date: Fri, 27 Mar 2015 18:37:46 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Eric B Munson cc: Andrew Morton , Jonathan Corbet , Davide Libenzi , Luiz Capitulino , Shuah Khan , Hugh Dickins , Andrea Arcangeli , Joern Engel , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [patch 1/2] mm, doc: cleanup and clarify munmap behavior for hugetlb memory In-Reply-To: <20150327135847.GB10747@akamai.com> Message-ID: References: <20150327135847.GB10747@akamai.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2015, Eric B Munson wrote: > > munmap(2) of hugetlb memory requires a length that is hugepage aligned, > > otherwise it may fail. Add this to the documentation. > > > > This also cleans up the documentation and separates it into logical > > units: one part refers to MAP_HUGETLB and another part refers to > > requirements for shared memory segments. > > > > Signed-off-by: David Rientjes > > --- > > If this is the route we are going to take, this behavoir needs to be > called out prominently in the mmap/munmap man page. > Yeah, that was my next step, but before we get mtk involved I was trying to get this merged since man2/mmap.2 already has a .I Documentation/vm/hugetlbpage.txt for MAP_HUGETLB so the man page patch can simply reference this addition to the file as justification.