From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754843AbbCaPPo (ORCPT ); Tue, 31 Mar 2015 11:15:44 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:23869 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbbCaPPk (ORCPT ); Tue, 31 Mar 2015 11:15:40 -0400 X-IronPort-AV: E=Sophos;i="5.11,502,1422918000"; d="scan'208";a="107804637" Date: Tue, 31 Mar 2015 17:15:23 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "Dhere, Chaitanya (C.)" cc: "oleg.drokin@intel.com" , "andreas.dilger@intel.com" , "gregkh@linuxfoundation.org" , "viro@zeniv.linux.org.uk" , "jinshan.xiong@intel.com" , "aybuke.147@gmail.com" , "john.hammond@intel.com" , "Julia.Lawall@lip6.fr" , "HPDD-discuss@lists.01.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user In-Reply-To: <20150331150933.GA2833@chaitanya-Ideapad-Z560> Message-ID: References: <20150331150933.GA2833@chaitanya-Ideapad-Z560> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2015, Dhere, Chaitanya (C.) wrote: > This patch replaces kzalloc and copy_from_user with memdup_user call > This change was detected with coccinelle tool > > Signed-off-by: Chaitanya Dhere > --- > drivers/staging/lustre/lustre/llite/file.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c > index 85e74d1..85b5567 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -2368,14 +2368,9 @@ ll_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > struct hsm_state_set *hss; > int rc; > > - hss = kzalloc(sizeof(*hss), GFP_NOFS); > - if (!hss) > - return -ENOMEM; > - > - if (copy_from_user(hss, (char *)arg, sizeof(*hss))) { > - OBD_FREE_PTR(hss); > - return -EFAULT; > - } > + hss = memdup_user((char *)arg, sizeof(*hss)); memdup_user will use the flag GFP_KERNEL, ie (__GFP_WAIT | __GFP_IO | __GFP_FS), rather than the flag GFP_NOFS, ie (__GFP_WAIT | __GFP_IO), that is specified. I don't know if this is a problem here. julia > + if (IS_ERR(hss)) > + return PTR_ERR(hss); > > rc = ll_hsm_state_set(inode, hss); > > -- > 1.7.9.5 >