From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752281AbbEKPsi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 May 2015 11:48:38 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11219 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751184AbbEKPsh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 May 2015 11:48:37 -0400
X-IronPort-AV: E=Sophos;i="5.13,408,1427752800"; 
   d="scan'208";a="142422499"
Date: Mon, 11 May 2015 17:48:31 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Michal Simek <michal.simek@xilinx.com>
cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org,
        Markus Elfring <elfring@users.sourceforge.net>
Subject: Re: [PATCH v2] net: ll_temac: Use one return statement instead of
 two
In-Reply-To: <5550CE4F.2070404@xilinx.com>
Message-ID: <alpine.DEB.2.10.1505111747150.2393@hadrien>
References: <3a0fa74dd703db5dac4816ef15b6a512ef0f2ec0.1431353091.git.michal.simek@xilinx.com>  <1431355371.2884.11.camel@perches.com> <5550CA19.8090404@xilinx.com> <1431358794.2884.17.camel@perches.com> <5550CE4F.2070404@xilinx.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > A coccinelle script might be rather more complicated
> > than the simpler grep above, but perhaps the script
> > could be a bit more complete as it could likely look
> > at more code indentation styles.
>
> Julia: Any comment?

Here is what I had in mind:

if (...) {
  ... when != goto l;
  return C;
}
return C;

C is a constant, to avoid that its value depends on the code in the ...

julia