From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbbE0NVf (ORCPT ); Wed, 27 May 2015 09:21:35 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:17912 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbbE0NVe (ORCPT ); Wed, 27 May 2015 09:21:34 -0400 X-IronPort-AV: E=Sophos;i="5.13,505,1427752800"; d="scan'208";a="128154719" Date: Wed, 27 May 2015 15:21:39 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Marcus Folkesson cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , Greg Donald , Julia Lawall , Daniel Baluta , Lai Siyao , Andriy Skulysh , Joe Perches , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: silence sparse warnings In-Reply-To: <1432730922-15202-1-git-send-email-marcus.folkesson@gmail.com> Message-ID: References: <1432730922-15202-1-git-send-email-marcus.folkesson@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe the explanation should more like "Make functions that are not used in other files static", rather than just silencing a tool. julia On Wed, 27 May 2015, Marcus Folkesson wrote: > Warnings reported by sparse: > drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol 'ptlrpc_ping' was not declared. Should it be static? > drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static? > drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6: warning: symbol 'pinger_check_timeout' was not declared. Should it be static? > drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21: warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static? > drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1: warning: symbol 'pet_list' was not declared. Should it be static? > > Signed-off-by: Marcus Folkesson > --- > drivers/staging/lustre/lustre/ptlrpc/pinger.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pinger.c b/drivers/staging/lustre/lustre/ptlrpc/pinger.c > index 5abb91c..ff9d904 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/pinger.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/pinger.c > @@ -91,7 +91,7 @@ int ptlrpc_obd_ping(struct obd_device *obd) > } > EXPORT_SYMBOL(ptlrpc_obd_ping); > > -int ptlrpc_ping(struct obd_import *imp) > +static int ptlrpc_ping(struct obd_import *imp) > { > struct ptlrpc_request *req; > > @@ -110,7 +110,7 @@ int ptlrpc_ping(struct obd_import *imp) > return 0; > } > > -void ptlrpc_update_next_ping(struct obd_import *imp, int soon) > +static void ptlrpc_update_next_ping(struct obd_import *imp, int soon) > { > int time = soon ? PING_INTERVAL_SHORT : PING_INTERVAL; > if (imp->imp_state == LUSTRE_IMP_DISCON) { > @@ -141,7 +141,7 @@ static inline int ptlrpc_next_reconnect(struct obd_import *imp) > return cfs_time_shift(obd_timeout); > } > > -long pinger_check_timeout(unsigned long time) > +static long pinger_check_timeout(unsigned long time) > { > struct timeout_item *item; > unsigned long timeout = PING_INTERVAL; > @@ -422,7 +422,7 @@ EXPORT_SYMBOL(ptlrpc_pinger_del_import); > * Register a timeout callback to the pinger list, and the callback will > * be called when timeout happens. > */ > -struct timeout_item *ptlrpc_new_timeout(int time, enum timeout_event event, > +static struct timeout_item *ptlrpc_new_timeout(int time, enum timeout_event event, > timeout_cb_t cb, void *data) > { > struct timeout_item *ti; > @@ -548,7 +548,7 @@ void ptlrpc_pinger_wake_up(void) > static int pet_refcount; > static int pet_state; > static wait_queue_head_t pet_waitq; > -LIST_HEAD(pet_list); > +static LIST_HEAD(pet_list); > static DEFINE_SPINLOCK(pet_lock); > > int ping_evictor_wake(struct obd_export *exp) > -- > 1.9.1 > >