From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753411AbbE1IdX (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 May 2015 04:33:23 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33582 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751844AbbE1IdT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 May 2015 04:33:19 -0400
X-IronPort-AV: E=Sophos;i="5.13,511,1427752800"; 
   d="scan'208";a="155632732"
Date: Thu, 28 May 2015 10:33:17 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Joe Perches <joe@perches.com>
cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Laurent Navet <laurent.navet@gmail.com>, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test
In-Reply-To: <1432800395.2846.205.camel@perches.com>
Message-ID: <alpine.DEB.2.10.1505281031250.2464@hadrien>
References: <1432758345-8095-1-git-send-email-laurent.navet@gmail.com>  <1432758608.2846.169.camel@perches.com> <20150528071444.GW11588@mwanda> <1432800395.2846.205.camel@perches.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 May 2015, Joe Perches wrote:

> On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
> > On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> > > Perhaps all of the uses like:
> > > 	goto <foo>;
> > > <foo>:
> > >
> > > could be modified.  There are ~150 in the kernel.
> >
> > Joe, these are a kind of style.  You're just directing a newbie into a
> > hornets nest.  Laurant, don't do listen to Joe unless you like getting
> > flamed.
>
> Hey Dan.
>
> I didn't direct anyone to do anything, but that's
> why I added Julia to cc's.
>
> Anyway, I think these are very equivalent style to
> the repeated:
>
> 	ret = foo();
> 	if (ret < 0)
> 		return ret;
> ...
> 	ret = bar();
> 	if (ret < 0)
> 		return ret;
>
> 	return ret;
>
> and people seem to prefer changing those.

Maybe if there is a whole sequence of them, it it is reasonable to keep
them.  But if there is just one, it seems complicated for nothing.  In the
big scheme of things, though, there are probably better things one could
do than changing all of them.

julia