From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755708AbbE3Pfn (ORCPT ); Sat, 30 May 2015 11:35:43 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:27839 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149AbbE3Pfi (ORCPT ); Sat, 30 May 2015 11:35:38 -0400 X-IronPort-AV: E=Sophos;i="5.13,522,1427752800"; d="scan'208";a="130061700" Date: Sat, 30 May 2015 17:35:33 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: =?ISO-8859-15?Q?Zolt=E1n_Lajos_Kis?= cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, Julia.Lawall@lip6.fr, kumari.radha3@gmail.com, mahfouz.saif.elyazal@gmail.com, gdonald@gmail.com, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: lustre: fix style issues in dt_object.c In-Reply-To: <1432999722-8407-1-git-send-email-zoltan.lajos.kis@gmail.com> Message-ID: References: <1432999722-8407-1-git-send-email-zoltan.lajos.kis@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1672311329-1433000133=:2314" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1672311329-1433000133=:2314 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Sat, 30 May 2015, Zoltán Lajos Kis wrote: > Fixes coding style issues for lustre/lustre/odbclass/dt_object.c that > were found by the checkpatch.pl tool. > > Signed-off-by: Zoltán Lajos Kis > > --- > --- Only one --- is needed. It is better for a patch to do only one thing. This one does a bunch of unrelated things (except for the checkpatch connection). julia > drivers/staging/lustre/lustre/obdclass/dt_object.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/dt_object.c b/drivers/staging/lustre/lustre/obdclass/dt_object.c > index b1eee0a..91fd7b9 100644 > --- a/drivers/staging/lustre/lustre/obdclass/dt_object.c > +++ b/drivers/staging/lustre/lustre/obdclass/dt_object.c > @@ -237,7 +237,8 @@ EXPORT_SYMBOL(dt_locate_at); > /** > * find a object named \a entry in given \a dfh->dfh_o directory. > */ > -static int dt_find_entry(const struct lu_env *env, const char *entry, void *data) > +static int dt_find_entry(const struct lu_env *env, > + const char *entry, void *data) > { > struct dt_find_hint *dfh = data; > struct dt_device *dt = dfh->dfh_dt; > @@ -330,9 +331,9 @@ static struct dt_object *dt_reg_open(const struct lu_env *env, > int result; > > result = dt_lookup_dir(env, p, name, fid); > - if (result == 0){ > + if (result == 0) > o = dt_locate(env, dt, fid); > - } else > + else > o = ERR_PTR(result); > > return o; > @@ -528,7 +529,6 @@ void dt_version_set(const struct lu_env *env, struct dt_object *o, > rc = dt_xattr_set(env, o, &vbuf, xname, 0, th, BYPASS_CAPA); > if (rc < 0) > CDEBUG(D_INODE, "Can't set version, rc %d\n", rc); > - return; > } > EXPORT_SYMBOL(dt_version_set); > > @@ -923,7 +923,7 @@ int dt_index_read(const struct lu_env *env, struct dt_device *dev, > ii->ii_version = dt_version_get(env, obj); > > /* walk the index and fill lu_idxpages with key/record pairs */ > - rc = dt_index_walk(env, obj, rdpg, dt_index_page_build ,ii); > + rc = dt_index_walk(env, obj, rdpg, dt_index_page_build, ii); > dt_read_unlock(env, obj); > > if (rc == 0) { > @@ -939,7 +939,7 @@ out: > } > EXPORT_SYMBOL(dt_index_read); > > -#if defined (CONFIG_PROC_FS) > +#if defined(CONFIG_PROC_FS) > > int lprocfs_dt_rd_blksize(char *page, char **start, off_t off, > int count, int *eof, void *data) > -- > 1.9.1 > > --8323329-1672311329-1433000133=:2314--