From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755143AbbFEPqA (ORCPT ); Fri, 5 Jun 2015 11:46:00 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:46390 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754951AbbFEPp7 (ORCPT ); Fri, 5 Jun 2015 11:45:59 -0400 X-IronPort-AV: E=Sophos;i="5.13,559,1427752800"; d="scan'208";a="163388485" Date: Fri, 5 Jun 2015 17:45:50 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Antonio Murdaca cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, julia.lawall@lip6.fr, akpm@linux-foundation.org Subject: Re: [PATCH] ethernet: micrel: use time_after_eq macro In-Reply-To: <1433514627-16845-1-git-send-email-antonio.murdaca@gmail.com> Message-ID: References: <1433514627-16845-1-git-send-email-antonio.murdaca@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Jun 2015, Antonio Murdaca wrote: > use time_after_eq macro for time comparison > > Signed-off-by: Antonio Murdaca > --- > drivers/net/ethernet/micrel/ksz884x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c > index 48d2aec..9bce30c 100644 > --- a/drivers/net/ethernet/micrel/ksz884x.c > +++ b/drivers/net/ethernet/micrel/ksz884x.c > @@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr) > > /* This is used to verify Wake-on-LAN is working. */ > if (hw_priv->pme_wait) { > - if (hw_priv->pme_wait <= jiffies) { > + if (time_after_eq(jiffies, hw_priv->pme_wait)) { There is also time_is_before_eq_jiffies. julia > hw_clr_wol_pme_status(&hw_priv->hw); > hw_priv->pme_wait = 0; > } > -- > 2.4.2 > >