From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: kernel coding style: prefer array to &array[0] ?
Date: Wed, 1 Jul 2015 14:26:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1507011426010.2374@hadrien> (raw)
In-Reply-To: <20150701121524.GA30834@mwanda>
On Wed, 1 Jul 2015, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 01:54:29PM +0200, Clemens Ladisch wrote:
> > Joe Perches wrote:
> > > It seems most in-kernel uses are 'array' rather than '&array[0]'
> > >
> > > Most of the time, using array is simpler to read than &array[0].
> > >
> > > Exceptions exists when addresses for consecutive members are
> > > used like func(&array[0], &array[1]);
> >
> > I use '&array[0]' when I want to get a pointer to a single object that
> > happens to be the first one in an array.
>
> Yeah. Of course, you're right. Otherwise it ends up confusing static
> checkers if you want the first element or the whole array.
>
> >
> > > Should this preference be put into checkpatch and/or CodingStyle?
> >
> > How about the following low-hanging fruit?
> >
> > foo(..., &array[0], ARRAY_SIZE(array), ...)
>
> Yes, to this also. I doubt checkpatch.pl will find a meaningful number
> of these but doing that is annoying thing.
Atcually, I find 236 of them, in 48 files.
julia
next prev parent reply other threads:[~2015-07-01 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 17:35 Joe Perches
2015-07-01 6:10 ` Julia Lawall
2015-07-01 11:54 ` Clemens Ladisch
2015-07-01 12:15 ` Dan Carpenter
2015-07-01 12:26 ` Julia Lawall [this message]
2015-07-01 14:53 ` Joe Perches
2015-07-01 22:33 ` Dmitry Torokhov
2015-07-01 23:04 ` Joe Perches
2015-07-05 21:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1507011426010.2374@hadrien \
--to=julia.lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®