From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753084AbbGMUvC (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jul 2015 16:51:02 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30549
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753314AbbGMUu7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jul 2015 16:50:59 -0400
X-IronPort-AV: E=Sophos;i="5.15,465,1432591200"; 
   d="scan'208";a="139912912"
Date: Mon, 13 Jul 2015 16:50:49 -0400 (EDT)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Thomas Gleixner <tglx@linutronix.de>
cc: LKML <linux-kernel@vger.kernel.org>, Ralf Baechle <ralf@linux-mips.org>,
        Jiang Liu <jiang.liu@linux.intel.com>, linux-mips@linux-mips.org,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [patch 04/12] MIPS/pci-rt3883: Consolidate chained IRQ handler
 install/remove
In-Reply-To: <20150713200714.765131309@linutronix.de>
Message-ID: <alpine.DEB.2.10.1507131650110.13108@hadrien>
References: <20150713200602.799079101@linutronix.de> <20150713200714.765131309@linutronix.de>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Mon, 13 Jul 2015, Thomas Gleixner wrote:

> Chained irq handlers usually set up handler data as well. We now have
> a function to set both under irq_desc->lock. Replace the two calls
> with one.

Are the original calls remaining?  If so, should there be a semantic patch
in the kernel to check for this, in case people ut the two calls in teh
future.

julia

>
> Search and conversion was done with coccinelle.
>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
>  arch/mips/pci/pci-rt3883.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: tip/arch/mips/pci/pci-rt3883.c
> ===================================================================
> --- tip.orig/arch/mips/pci/pci-rt3883.c
> +++ tip/arch/mips/pci/pci-rt3883.c
> @@ -225,8 +225,7 @@ static int rt3883_pci_irq_init(struct de
>  		return -ENODEV;
>  	}
>
> -	irq_set_handler_data(irq, rpc);
> -	irq_set_chained_handler(irq, rt3883_pci_irq_handler);
> +	irq_set_chained_handler_and_data(irq, rt3883_pci_irq_handler, rpc);
>
>  	return 0;
>  }
>
>
>