From: Julia Lawall <julia.lawall@lip6.fr>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] Staging: vt6656: Bool tests don't need comparisons
Date: Sun, 13 Sep 2015 18:18:04 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1509131817410.2474@hadrien> (raw)
In-Reply-To: <1442160279-6334-3-git-send-email-shraddha.6596@gmail.com>
On Sun, 13 Sep 2015, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
>
> Change in v4-
> No changes
This needs to go under the ---. It is not information that needs to be
preserved in the git log.
julia
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/vt6656/wcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 3cbf479..c8e69ff 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
> ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
> priv->free_cmd_queue--;
>
> - if (priv->cmd_running == false)
> + if (!priv->cmd_running)
> vnt_cmd_complete(priv);
>
> return true;
> --
> 2.1.4
>
>
next prev parent reply other threads:[~2015-09-13 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:04 [PATCH v4 3/3] Staging: rtl8188eu: " Shraddha Barke
2015-09-13 16:04 ` [PATCH v4 1/3] Staging: rtl8723au: core: " Shraddha Barke
2015-09-13 16:04 ` [PATCH v4 2/3] Staging: vt6656: " Shraddha Barke
2015-09-13 16:18 ` Julia Lawall [this message]
2015-09-13 16:18 ` [PATCH v4 3/3] Staging: rtl8188eu: " Julia Lawall
2015-09-13 16:27 Shraddha Barke
2015-09-13 16:27 ` [PATCH v4 2/3] Staging: vt6656: " Shraddha Barke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1509131817410.2474@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Jes.Sorensen@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®