From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932791AbbI3VOr (ORCPT ); Wed, 30 Sep 2015 17:14:47 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35973 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932595AbbI3VOl (ORCPT ); Wed, 30 Sep 2015 17:14:41 -0400 Date: Wed, 30 Sep 2015 14:14:38 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Oleg Nesterov cc: Andrew Morton , Kyle Walker , Michal Hocko , Stanislav Kozina , Tetsuo Handa , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process() In-Reply-To: <20150930182405.GA15238@redhat.com> Message-ID: References: <20150930182405.GA15238@redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Oleg Nesterov wrote: > The fatal_signal_pending() was added to suppress unnecessary "sharing > same memory" message, but it can't 100% help anyway because it can be > false-negative; SIGKILL can be already dequeued. > > And worse, it can be false-positive due to exec or coredump. exec is > mostly fine, but coredump is not. It is possible that the group leader > has the pending SIGKILL because its sub-thread originated the coredump, > in this case we must not skip this process. > > We could probably add the additional ->group_exit_task check but this > pach just removes the wrong check along with pr_info(). > > Signed-off-by: Oleg Nesterov Acked-by: David Rientjes