From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbJNCe1 (ORCPT ); Tue, 13 Oct 2015 22:34:27 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35200 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbJNCeZ (ORCPT ); Tue, 13 Oct 2015 22:34:25 -0400 Date: Tue, 13 Oct 2015 19:34:23 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: yalin wang cc: akpm@linux-foundation.org, vbabka@suse.cz, mgorman@techsingularity.net, mhocko@suse.com, js1304@gmail.com, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, alexander.h.duyck@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm, page_alloc: reserve pageblocks for high-order atomic allocations on demand -fix In-Reply-To: <1444700544-22666-1-git-send-email-yalin.wang2010@gmail.com> Message-ID: References: <1444700544-22666-1-git-send-email-yalin.wang2010@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015, yalin wang wrote: > There is a redundant check and a memory leak introduced by a patch in > mmotm. This patch removes an unlikely(order) check as we are sure order > is not zero at the time. It also checks if a page is already allocated > to avoid a memory leak. > > This is a fix to the mmotm patch > mm-page_alloc-reserve-pageblocks-for-high-order-atomic-allocations-on-demand.patch > > Signed-off-by: yalin wang > Acked-by: Mel Gorman Acked-by: David Rientjes Cool find!