From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbbJNMao (ORCPT ); Wed, 14 Oct 2015 08:30:44 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33418 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753156AbbJNMam (ORCPT ); Wed, 14 Oct 2015 08:30:42 -0400 X-IronPort-AV: E=Sophos;i="5.17,681,1437429600"; d="scan'208";a="182757315" Date: Wed, 14 Oct 2015 14:30:35 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Ben Skeggs cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 In-Reply-To: <201510141846.22W2v2Rw%fengguang.wu@intel.com> Message-ID: References: <201510141846.22W2v2Rw%fengguang.wu@intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please check whether not releasing the lock is intentional. julia On Wed, 14 Oct 2015, kbuild test robot wrote: > CC: kbuild-all@01.org > CC: linux-kernel@vger.kernel.org > TO: Ben Skeggs > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 5b5f1455272e23f4e7889cec37228802d8d01adf > commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remove dependence on namedb/engctx lookup > date: 7 weeks ago > :::::: branch date: 16 hours ago > :::::: commit date: 7 weeks ago > > >> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git remote update linus > git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936 > vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c > > 344c2d42 Ben Skeggs 2015-08-20 61 } > 344c2d42 Ben Skeggs 2015-08-20 62 > 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan * > 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags) > 344c2d42 Ben Skeggs 2015-08-20 65 { > 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags; > 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, flags); > 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) { > 344c2d42 Ben Skeggs 2015-08-20 69 *rflags = flags; > 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chid]; > 344c2d42 Ben Skeggs 2015-08-20 71 } > 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->lock, flags); > 344c2d42 Ben Skeggs 2015-08-20 73 return NULL; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >