From: Paul Osmialowski <p.osmialowsk@samsung.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jonathan Corbet <corbet@lwn.net>, Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
Kay Sievers <kay.sievers@vrfy.org>, Joe Perches <joe@perches.com>,
Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Marcin Niesluchowski <m.niesluchow@samsung.com>,
Karol Lewandowski <k.lewandowsk@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
Paul Osmialowski <p.osmialowsk@samsung.com>
Subject: Re: [RFC v3 8/9] kmsg: add predefined _PID, _TID, _COMM keywords to kmsg* log dict
Date: Tue, 20 Oct 2015 13:16:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1510201313220.13957@AMDC1262.digital.local> (raw)
In-Reply-To: <CALCETrW2CgnS5pwS278ipLOSQi95UOT-osoSpshGwFmBf7TgRQ@mail.gmail.com>
Hi Andy,
On Mon, 19 Oct 2015, Andy Lutomirski wrote:
> On Mon, Oct 19, 2015 at 5:58 AM, Paul Osmialowski
> <p.osmialowsk@samsung.com> wrote:
>> From: Marcin Niesluchowski <m.niesluchow@samsung.com>
>>
>> kmsg* devices write operation wrote no dict along with message
>> Due to usage of kmsg devices in userspace dict has been added
>> identifying pid, tid and comm of writing process.
>
> Does this affect even the normal /dev/kmsg?
Yes.
>
>> -static int kmsg_sys_write(int minor, int level, const char *fmt, ...)
>> +static size_t set_kmsg_dict(char *buf)
>> +{
>> + size_t len;
>> +
>> + len = sprintf(buf, "_PID=%d", task_tgid_nr(current)) + 1;
>> + len += sprintf(buf + len, "_TID=%d", task_pid_nr(current)) + 1;
>> + memcpy(buf + len, "_COMM=", 6);
>> + len += 6;
>> + get_task_comm(buf + len, current);
>> + while (buf[len] != '\0')
>> + len++;
>
> len += strlen(buf); ?
>
> Is it obvious for some reason that this doesn't overflow buf?
>
KMSG_DICT_MAX_LEN sets architecture-intepentent max size.
> Why is task_pid_nr acceptable here? Isn't this intended for use in namespaces?
>
task_tgid_nr - process id (pid as seen in userspace),
task_pid_nr - thread id
Thanks,
Paul
next prev parent reply other threads:[~2015-10-20 11:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:58 [RFC v3 0/9] Additional kmsg devices Paul Osmialowski
2015-10-19 12:58 ` [RFC v3 1/9] printk: extract kmsg-related routines from printk.c to kmsg.c Paul Osmialowski
2015-10-19 13:53 ` kbuild test robot
2015-10-19 13:59 ` kbuild test robot
2015-10-19 12:58 ` [RFC v3 2/9] printk: add one function for storing log in proper format Paul Osmialowski
2015-10-19 12:58 ` [RFC v3 3/9] kmsg: introduce additional kmsg devices support Paul Osmialowski
2015-10-19 14:10 ` kbuild test robot
2015-10-19 12:58 ` [RFC v3 4/9] kmsg: add additional buffers support to memory class Paul Osmialowski
2015-10-19 13:54 ` kbuild test robot
2015-10-19 12:58 ` [RFC v3 5/9] kmsg: add function for adding and deleting additional buffers Paul Osmialowski
2015-10-19 18:20 ` kbuild test robot
2015-10-19 12:58 ` [RFC v3 6/9] kmsg: add ioctl for adding and deleting kmsg* devices Paul Osmialowski
2015-10-19 13:19 ` Arnd Bergmann
2015-10-19 12:58 ` [RFC v3 7/9] kmsg: add ioctl for kmsg* devices operating on buffers Paul Osmialowski
2015-10-19 12:58 ` [RFC v3 8/9] kmsg: add predefined _PID, _TID, _COMM keywords to kmsg* log dict Paul Osmialowski
2015-10-19 13:53 ` kbuild test robot
2015-10-19 14:11 ` kbuild test robot
2015-10-19 17:45 ` Andy Lutomirski
2015-10-20 11:16 ` Paul Osmialowski [this message]
2015-10-20 18:19 ` Andy Lutomirski
2015-10-19 12:58 ` [RFC v3 9/9] kmsg: selftests Paul Osmialowski
2015-10-22 0:32 ` Michael Ellerman
2015-10-19 13:26 ` [RFC v3 0/9] Additional kmsg devices Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1510201313220.13957@AMDC1262.digital.local \
--to=p.osmialowsk@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=k.lewandowsk@samsung.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=m.niesluchow@samsung.com \
--cc=pmladek@suse.cz \
--cc=shuahkh@osg.samsung.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®