From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756529AbbJ1Xze (ORCPT ); Wed, 28 Oct 2015 19:55:34 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33657 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756464AbbJ1Xzd (ORCPT ); Wed, 28 Oct 2015 19:55:33 -0400 Date: Wed, 28 Oct 2015 16:55:31 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Aristeu Rozanski cc: Michal Hocko , linux-kernel@vger.kernel.org, Greg Thelen , Johannes Weiner , linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [PATCH] oom_kill: add option to disable dump_stack() In-Reply-To: <20151027175140.GC14722@redhat.com> Message-ID: References: <1445634150-27992-1-git-send-email-arozansk@redhat.com> <20151026172012.GC9779@dhcp22.suse.cz> <20151026174048.GP15046@redhat.com> <20151027080920.GA9891@dhcp22.suse.cz> <20151027154341.GA14722@redhat.com> <20151027162047.GK9891@dhcp22.suse.cz> <20151027175140.GC14722@redhat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Oct 2015, Aristeu Rozanski wrote: > Hi Michal, > On Tue, Oct 27, 2015 at 05:20:47PM +0100, Michal Hocko wrote: > > Yes this is a mess. But I think it is worth cleaning up. > > dump_stack_print_info (arch independent) has a log level parameter. > > show_stack_log_lvl (x86) has a loglevel parameter which is unused. > > > > I haven't checked other architectures but the transition doesn't have to > > be all at once I guess. > > Ok, will keep working on it then. > No objection on changing the loglevel of the stack trace from the oom killer and the bonus is that we can avoid yet another tunable, yay!